[GR-18163] Coerce the inherit argument to a boolean in Module#{const_defined?,const_get}

PullRequest: truffleruby/2382

Author: eregon

CHANGELOG.md

@@ -46,6 +46,7 @@ Compatibility:
 * Implement `rb_lastline_set` (#2170).
 * Implemented `Module#const_source_location` (#2212, @tomstuart and @wildmaples).
 * Do not call `File.exist?` in `Dir.glob` as `File.exist?` is often mocked (#2236, @gogainda).
+* Coerce the inherit argument to a boolean in `Module#const_defined?` and `Module#const_get` (#2240).
 
 Performance:
 

ci.jsonnet

@@ -498,7 +498,7 @@ local composition_environment = utils.add_inclusion_tracking(part_definitions, "
       "ruby-test-specs-linux-11":    $.platform.linux  + $.jdk.v11 + $.env.jvm + gate_no_build + $.use.build_no_clean + $.run.test_unit_tck + native_config + $.run.clean + $.run.test_specs + { timelimit: "50:00" },
       "ruby-test-specs-darwin":      $.platform.darwin + $.jdk.v8  + $.env.jvm + gate_no_build + $.use.build_no_clean + $.run.test_unit_tck + native_config + $.run.clean + $.run.test_specs + { timelimit: "01:35:00" },
       "ruby-test-specs-darwin-11":   $.platform.darwin + $.jdk.v11 + $.env.jvm + gate_no_build + $.use.build_no_clean + $.run.test_unit_tck + native_config + $.run.clean + $.run.test_specs + { timelimit: "01:35:00" },
-      # "ruby-test-fast-linux-arm64":  $.platform.linux_arm64 + $.jdk.v11 + $.env.jvm + gate + $.run.test_fast + native_config + { timelimit: "30:00" }, # GR-29056
+      "ruby-test-fast-linux-arm64":  $.platform.linux_arm64 + $.jdk.v11 + $.env.jvm + gate + $.run.test_fast + native_config + { timelimit: "30:00" },
       "ruby-test-fast-linux":        $.platform.linux  + $.jdk.v8  + $.env.jvm + gate + $.run.test_fast + { timelimit: "30:00" },  # To catch missing slow tags
       "ruby-test-mri-linux":         $.platform.linux  + $.jdk.v8  + $.env.jvm + gate + $.run.test_mri + { timelimit: "45:00" },
       "ruby-test-mri-darwin":        $.platform.darwin + $.jdk.v8  + $.env.jvm + gate + $.run.test_mri + { timelimit: "01:30:00" },

spec/ruby/core/module/const_defined_spec.rb

@@ -40,6 +40,11 @@
     ConstantSpecs::ContainerA::ChildA.const_defined?(:CS_CONST4, true).should be_true
   end
 
+  it "coerces the inherit flag to a boolean" do
+    ConstantSpecs::ContainerA::ChildA.const_defined?(:CS_CONST4, nil).should be_false
+    ConstantSpecs::ContainerA::ChildA.const_defined?(:CS_CONST4, :true).should be_true
+  end
+
   it "returns true if the given String names a constant defined in the receiver" do
     ConstantSpecs.const_defined?("CS_CONST2").should == true
     ConstantSpecs.const_defined?("ModuleA").should == true

spec/ruby/core/module/const_get_spec.rb

@@ -88,6 +88,14 @@
     end.should raise_error(NameError)
   end
 
+  it "coerces the inherit flag to a boolean" do
+    ConstantSpecs::ContainerA::ChildA.const_get(:CS_CONST4, :true).should == :const4
+
+    -> do
+      ConstantSpecs::ContainerA::ChildA.const_get(:CS_CONST1, nil)
+    end.should raise_error(NameError)
+  end
+
   it "accepts a toplevel scope qualifier" do
     ConstantSpecs.const_get("::CS_CONST1").should == :const1
   end

src/main/java/org/truffleruby/core/module/ModuleNodes.java

@@ -941,6 +941,11 @@ protected RubyNode coerceToString(RubyNode name) {
             return NameToJavaStringNode.create(name);
         }
 
+        @CreateCast("inherit")
+        protected RubyNode coerceToBoolean(RubyNode inherit) {
+            return BooleanCastWithDefaultNodeGen.create(true, inherit);
+        }
+
         @TruffleBoundary
         @Specialization
         protected boolean isConstDefined(RubyModule module, String fullName, boolean inherit, boolean checkName) {
@@ -968,6 +973,11 @@ protected RubyNode coerceToSymbolOrString(RubyNode name) {
             return ToStringOrSymbolNodeGen.create(name);
         }
 
+        @CreateCast("inherit")
+        protected RubyNode coerceToBoolean(RubyNode inherit) {
+            return BooleanCastWithDefaultNodeGen.create(true, inherit);
+        }
+
         // Symbol
 
         @Specialization(guards = "inherit")