Skip to content

Commit 5c30d9c

Browse files
committed
We no longer need -Wno-format-invalid-specifier
* rbsprintf() no longer uses printf extensions.
1 parent 275c219 commit 5c30d9c

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

lib/truffle/rbconfig.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,13 @@ module RbConfig
7272
strip = Truffle::Boot.toolchain_executable(:STRIP)
7373

7474
strip = "#{strip} --keep-section=.llvmbc" unless Truffle::Platform.darwin?
75-
gcc, clang = false, true
7675
else
7776
if Truffle::Platform.linux?
7877
ar = 'gcc-ar'
7978
cc = 'gcc' # -std=gnu99 ?
8079
cxx = 'g++'
8180
ranlib = 'gcc-ranlib'
8281
strip = 'strip -S -x'
83-
gcc, clang = true, false
8482
elsif Truffle::Platform.darwin?
8583
ar = 'ar'
8684
cc = 'clang'
@@ -90,7 +88,6 @@ module RbConfig
9088
# This is notably necessary for grpc where the current logic does not append -x for TruffleRuby:
9189
# https://github.com/grpc/grpc/blob/54f65e0dbd2151a3ba2ad364327c0c31b200a5ae/src/ruby/ext/grpc/extconf.rb#L125-L126
9290
strip = 'strip -A -n -x'
93-
gcc, clang = false, true
9491
cflags_pre = '-fdeclspec '
9592
else
9693
raise 'Unknown platform'
@@ -107,7 +104,6 @@ module RbConfig
107104
'-Wno-incompatible-pointer-types', # Fix byebug 8.2.1 compile (st_data_t error)
108105
'-Wno-format-extra-args', # Our PRIsVALUE generates this because compilers ignore printf extensions
109106
]
110-
warnflags << '-Wno-format-invalid-specifier' if clang # Our PRIsVALUE generates this because compilers ignore printf extensions
111107

112108
defs = ''
113109
cppflags = ''

0 commit comments

Comments
 (0)