[GR-20446] Raise argument error when not enough printf arguments.

PullRequest: truffleruby/1245

Author: eregon

CHANGELOG.md

@@ -60,6 +60,7 @@ Bug fixes:
 * Fixed `String#capitalize!` for strings that weren't full ASCII.
 * Fixed enumeration issue in `ENV.{select, filter}`.
 * Fixed `Complex` and `Rational` should be frozen after initializing.
+* Fixed `printf` should raise error when not enough arguments for positional argument.
 
 Compatibility:
 

spec/tags/core/file/printf_tags.txt

@@ -1,7 +1,6 @@
 fails:File#printf other formats c raises ArgumentError if argument is an empty string
 fails:File#printf other formats c supports Unicode characters
 fails:File#printf other formats s does not try to convert with to_str
-fails:File#printf flags (digit)$ raises exception if argument number is bigger than actual arguments list
 fails:File#printf flags # applies to format o does nothing for negative argument
 fails:File#printf flags # applies to formats bBxX does nothing for zero argument
 fails:File#printf flags # applies to formats aAeEfgG forces a decimal point to be added, even if no digits follow

spec/tags/core/kernel/printf_tags.txt

@@ -116,7 +116,6 @@ fails:Kernel.printf formatting io is specified reference by name %{name} style c
 fails:Kernel.printf formatting io is not specified other formats c raises ArgumentError if argument is an empty string
 fails:Kernel.printf formatting io is not specified other formats c supports Unicode characters
 fails:Kernel.printf formatting io is not specified other formats s does not try to convert with to_str
-fails:Kernel.printf formatting io is not specified flags (digit)$ raises exception if argument number is bigger than actual arguments list
 fails:Kernel.printf formatting io is not specified flags # applies to format o does nothing for negative argument
 fails:Kernel.printf formatting io is not specified flags # applies to formats bBxX does nothing for zero argument
 fails:Kernel.printf formatting io is not specified flags # applies to formats aAeEfgG forces a decimal point to be added, even if no digits follow

spec/tags/core/kernel/sprintf_tags.txt

@@ -4,7 +4,6 @@ fails:Kernel#sprintf raises Encoding::CompatibilityError if both encodings are A
 fails:Kernel#sprintf other formats c raises ArgumentError if argument is an empty string
 fails:Kernel#sprintf other formats c supports Unicode characters
 fails:Kernel#sprintf other formats s does not try to convert with to_str
-fails:Kernel#sprintf flags (digit)$ raises exception if argument number is bigger than actual arguments list
 fails:Kernel#sprintf flags # applies to format o does nothing for negative argument
 fails:Kernel#sprintf flags # applies to formats bBxX does nothing for zero argument
 fails:Kernel#sprintf flags # applies to formats aAeEfgG forces a decimal point to be added, even if no digits follow
@@ -21,7 +20,6 @@ fails:Kernel.sprintf raises Encoding::CompatibilityError if both encodings are A
 fails:Kernel.sprintf other formats c raises ArgumentError if argument is an empty string
 fails:Kernel.sprintf other formats c supports Unicode characters
 fails:Kernel.sprintf other formats s does not try to convert with to_str
-fails:Kernel.sprintf flags (digit)$ raises exception if argument number is bigger than actual arguments list
 fails:Kernel.sprintf flags # applies to format o does nothing for negative argument
 fails:Kernel.sprintf flags # applies to formats bBxX does nothing for zero argument
 fails:Kernel.sprintf flags # applies to formats aAeEfgG forces a decimal point to be added, even if no digits follow

spec/tags/core/string/modulo_tags.txt

@@ -9,7 +9,6 @@ fails:String#% other formats c raises ArgumentError if argument is an empty stri
 fails:String#% other formats c supports Unicode characters
 fails:String#% other formats s does not try to convert with to_str
 fails:String#% other formats % alone raises an ArgumentError
-fails:String#% flags (digit)$ raises exception if argument number is bigger than actual arguments list
 fails:String#% flags # applies to format o does nothing for negative argument
 fails:String#% flags # applies to formats bBxX does nothing for zero argument
 fails:String#% flags # applies to formats aAeEfgG forces a decimal point to be added, even if no digits follow

spec/tags/core/string/percent_tags.txt

@@ -2,7 +2,6 @@ fails:StringIO#printf formatting other formats c raises ArgumentError if argumen
 fails:StringIO#printf formatting other formats c supports Unicode characters
 fails:StringIO#printf formatting other formats s does not try to convert with to_str
 fails:StringIO#printf formatting other formats % is escaped by %
-fails:StringIO#printf formatting flags (digit)$ raises exception if argument number is bigger than actual arguments list
 fails:StringIO#printf formatting flags # applies to format o does nothing for negative argument
 fails:StringIO#printf formatting flags # applies to formats bBxX does nothing for zero argument
 fails:StringIO#printf formatting flags # applies to formats aAeEfgG forces a decimal point to be added, even if no digits follow

spec/tags/library/stringio/printf_tags.txt

@@ -106,6 +106,9 @@ public List<SprintfConfig> parse() {
                             if (config.getAbsoluteArgumentIndex() != null) {
                                 throw new InvalidFormatException("value given twice - " + r.getNumber() + "$");
                             }
+                            if (arguments.length < r.getNumber()) {
+                                throw new InvalidFormatException("too few arguments");
+                            }
                             checkPosArg(argType, r.getNumber());
                             argType = ArgType.NUMBERED;
                             argTypeSet = true;