Skip to content

Commit 587e3e7

Browse files
committed
Remove --cpusampler.Mode, it has no effect with the new CPUSampler implementation
1 parent 8990c54 commit 587e3e7

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

doc/contributor/profiling.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,9 @@ Creating the flame graph is a multi-stage process. First, we need to profile the
4848
with the JSON formatter:
4949

5050
```bash
51-
jt ruby --cpusampler --cpusampler.Mode=roots --cpusampler.Output=json -e 'p :hello' > simple-app.json
51+
jt ruby --cpusampler --cpusampler.Output=json -e 'p :hello' > simple-app.json
5252
```
5353

54-
The `--cpusampler.Mode=roots` option will sample roots, including inlined functions,
55-
which can often give a better idea of what is contributing to the overall method execution time.
56-
5754
The JSON profiler formatter encodes call graph information that isn't available in the
5855
histogram format. To make a flame graph out of this output, however, we need to transform
5956
it into a format that folds the call stack samples into single lines. This can be done

spec/truffle/tools_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def foo
6868
t.kill
6969
t.join
7070
RUBY
71-
out = ruby_exe(code, options: "--cpusampler --cpusampler.Mode=roots")
71+
out = ruby_exe(code, options: "--cpusampler")
7272
out.should.include?(":kill")
7373
out.should.include?("block in Object#foo")
7474
out.should_not.include?('KillException')

tool/jt.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
JDEBUG = '--vm.agentlib:jdwp=transport=dt_socket,server=y,address=8000,suspend=y'
4040
METRICS_REPS = Integer(ENV['TRUFFLERUBY_METRICS_REPS'] || 10)
41-
DEFAULT_PROFILE_OPTIONS = %w[--cpusampler --cpusampler.Mode=roots --cpusampler.Output=json]
41+
DEFAULT_PROFILE_OPTIONS = %w[--cpusampler --cpusampler.Output=json]
4242

4343
RUBOCOP_INCLUDE_LIST = %w[
4444
lib/cext

0 commit comments

Comments
 (0)