Disable the Lint/LiteralAsCondition rule since it incorrectly flags while true

Author: eregon

.rubocop.yml

@@ -179,10 +179,8 @@ Lint/InheritException:
 
 Lint/LiteralAsCondition:
   Description: Checks of literals used in conditions.
-  Details: >-
-      Pattern `while true` is allowed, disable the cop with
-      `while true # rubocop:disable Lint/LiteralAsCondition` in this case.
-  Enabled: true
+  # disabled, it prevents `while true`, which is useful
+  Enabled: false
 
 # Supports --auto-correct
 Lint/LiteralInInterpolation:

src/main/ruby/truffleruby/core/array.rb

@@ -1042,7 +1042,7 @@ def sample(count=undefined, options=undefined)
       k = rng.rand(size)
       spin = false
 
-      while true # rubocop:disable Lint/LiteralAsCondition
+      while true
         j = 0
         while j < i
           if k == result[j]
@@ -1085,7 +1085,7 @@ def sample(count=undefined, options=undefined)
     while i < count
       k = rng.rand(size)
 
-      while true # rubocop:disable Lint/LiteralAsCondition
+      while true
         if result_set.include?(k)
           k = rng.rand(size)
         else

src/main/ruby/truffleruby/core/enumerable.rb

@@ -537,7 +537,7 @@ def cycle(many=nil)
         i += 1
       end
     else
-      while true # rubocop:disable Lint/LiteralAsCondition
+      while true
         cache.each { |o| yield o }
       end
     end

src/main/ruby/truffleruby/core/kernel.rb

@@ -434,7 +434,7 @@ def loop
     return to_enum(:loop) { Float::INFINITY } unless block_given?
 
     begin
-      while true # rubocop:disable Lint/LiteralAsCondition
+      while true
         yield
       end
     rescue StopIteration => si

src/main/ruby/truffleruby/core/posix.rb

@@ -346,7 +346,7 @@ def self.with_array_of_strings_pointer(strings)
   # gets as soon as it gets something.
 
   def self.read_string_at_least_one_byte(io, count)
-    while true # rubocop:disable Lint/LiteralAsCondition
+    while true
       # must call #read_string in order to properly support polyglot STDIO
       string, errno = read_string(io, count)
       return string if errno == 0

src/main/ruby/truffleruby/core/range.rb

@@ -26,8 +26,6 @@
 # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-# rubocop:disable Lint/LiteralAsCondition
-
 class Range
 
   include Enumerable