Optimize exceptions

PullRequest: truffleruby/530

Author: eregon

src/main/java/org/truffleruby/core/fiber/FiberLayout.java

@@ -34,7 +34,7 @@ DynamicObject createFiber(DynamicObjectFactory factory,
                               DynamicObject rubyThread,
                               @Volatile @Nullable DynamicObject lastResumedByFiber,
                               @Volatile boolean alive,
-                              @Volatile @Nullable Thread thread,
+                              @Nullable Thread thread,
                               @Volatile boolean transferred);
 
     boolean isFiber(DynamicObject object);

src/main/java/org/truffleruby/core/thread/ThreadNodes.java

@@ -430,7 +430,7 @@ public DynamicObject wakeup(DynamicObject rubyThread,
                                     @Cached("new()") YieldNode yieldNode) {
             final DynamicObject currentFiber = Layouts.THREAD.getFiberManager(rubyThread).getCurrentFiberRacy();
             final Thread thread = Layouts.FIBER.getThread(currentFiber);
-            if (thread == null) {
+            if (!Layouts.FIBER.getAlive(currentFiber) || thread == null) {
                 throw new RaiseException(getContext(), coreExceptions().threadErrorKilledThread(this));
             }
 

src/main/java/org/truffleruby/language/RubyBaseRootNode.java

@@ -28,6 +28,15 @@ public final SourceSection getSourceSection() {
         return sourceSection;
     }
 
+    // NOTE (eregon, 11 Jan 2019): TruffleStackTrace calls this on the fast path, so it should constant-fold.
+    @Override
+    public boolean isInternal() {
+        if (sourceSection != null) {
+            return sourceSection.getSource().isInternal();
+        }
+        return false;
+    }
+
     @Override
     public boolean isCaptureFramesForTrace() {
         return true;

tool/jt.rb

@@ -160,8 +160,8 @@ def find_graal_javacmd_and_options
     elsif graal_home = find_auto_graal_home
       javacmd = "#{find_graal_java_home(graal_home)}/bin/java"
       graal_jars = [
-        "#{graal_home}/mxbuild/dists/graal.jar",
-        "#{graal_home}/mxbuild/dists/graal-management.jar"
+        "#{graal_home}/mxbuild/dists/jdk1.8/graal.jar",
+        "#{graal_home}/mxbuild/dists/jdk1.8/graal-management.jar"
       ]
       vm_args = [
         '-XX:+UnlockExperimentalVMOptions',
@@ -179,7 +179,7 @@ def find_graal_javacmd_and_options
   def find_auto_graal_home
     sibling_compiler = File.expand_path('../graal/compiler', TRUFFLERUBY_DIR)
     return nil unless Dir.exist?(sibling_compiler)
-    return nil unless File.exist?("#{sibling_compiler}/mxbuild/dists/graal-compiler.jar")
+    return nil unless File.exist?("#{sibling_compiler}/mxbuild/dists/jdk1.8/graal-compiler.jar")
     sibling_compiler
   end
 
@@ -723,7 +723,7 @@ def run_ruby(*args)
         vm_args << "-J-Dgraal.TraceTruffleCompilation=true"
       when '--igv', '--igv-full'
         graal = true
-        vm_args << (arg == '--igv-full') ? "-J-Dgraal.Dump=:2" : "-J-Dgraal.Dump=TruffleTree,PartialEscape:2"
+        vm_args << (arg == '--igv-full' ? "-J-Dgraal.Dump=:2" : "-J-Dgraal.Dump=TruffleTree,PartialEscape:2")
         vm_args << "-J-Dgraal.PrintGraphFile=true" unless igv_running?
         vm_args << "-J-Dgraal.PrintBackendCFG=false"
       when '--no-print-cmd'