[GR-19220] Add Module#refinements (#3093)

PullRequest: truffleruby/3878

Author: eregon

.gitattributes

@@ -2,6 +2,8 @@
 
 /CHANGELOG.md merge=union
 
+/spec/truffleruby.next-specs merge=union
+
 # Rules for GitHub's Linguist language-classification system. We're abusing the
 # 'vendored' attribute to exclude files as a lot of this isn't really vendored,
 # and a whole lot of actually vendored code isn't listed! What we want to do is

CHANGELOG.md

@@ -26,6 +26,7 @@ Compatibility:
 * Add optional `timeout` argument to `Thread::Queue#pop` (#3039, @itarato).
 * Add optional `timeout` argument to `Thread::SizedsQueue#pop` (#3039, @itarato).
 * Handle `long long` and aliases in `Fiddle` (#3128, @eregon).
+* Add `Module#refinements` (#3039, @itarato).
 
 Performance:
 

spec/tags/truffle/methods_tags.txt

@@ -114,3 +114,4 @@ fails:Public methods on UnboundMethod should include private?
 fails:Public methods on UnboundMethod should include protected?
 fails:Public methods on UnboundMethod should include public?
 fails:Public methods on String should not include bytesplice
+fails:Public methods on Module should not include refinements

spec/truffleruby.next-specs

@@ -29,3 +29,5 @@ spec/ruby/core/queue/shift_spec.rb
 spec/ruby/core/sizedqueue/deq_spec.rb
 spec/ruby/core/sizedqueue/pop_spec.rb
 spec/ruby/core/sizedqueue/shift_spec.rb
+
+spec/ruby/core/module/refinements_spec.rb

src/main/java/org/truffleruby/core/module/ModuleNodes.java

@@ -10,6 +10,7 @@
 package org.truffleruby.core.module;
 
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.LinkedHashSet;
@@ -37,7 +38,6 @@
 import org.truffleruby.builtins.CoreMethodArrayArgumentsNode;
 import org.truffleruby.builtins.CoreMethodNode;
 import org.truffleruby.annotations.CoreModule;
-import org.truffleruby.builtins.NonStandard;
 import org.truffleruby.annotations.Primitive;
 import org.truffleruby.builtins.PrimitiveArrayArgumentsNode;
 import org.truffleruby.builtins.PrimitiveNode;
@@ -2315,7 +2315,6 @@ protected RubyArray usedModules() {
 
     }
 
-    @NonStandard
     @CoreMethod(names = "used_refinements", onSingleton = true)
     public abstract static class UsedRefinementsNode extends CoreMethodArrayArgumentsNode {
 
@@ -2326,15 +2325,24 @@ protected RubyArray usedRefinements() {
             final DeclarationContext declarationContext = RubyArguments.getDeclarationContext(frame);
             final Set<RubyModule> refinements = new HashSet<>();
             for (RubyModule[] refinementModules : declarationContext.getRefinements().values()) {
-                for (RubyModule refinementModule : refinementModules) {
-                    refinements.add(refinementModule);
-                }
+                Collections.addAll(refinements, refinementModules);
             }
             return createArray(refinements.toArray());
         }
 
     }
 
+    @CoreMethod(names = "refinements")
+    public abstract static class RefinementsNode extends CoreMethodArrayArgumentsNode {
+
+        @TruffleBoundary
+        @Specialization
+        protected RubyArray refinements(RubyModule self) {
+            return createArray(self.fields.getRefinements().values().toArray());
+        }
+
+    }
+
     @GenerateUncached
     @ImportStatic(ArrayGuards.class)
     public abstract static class SetMethodVisibilityNode extends RubyBaseNode {

test/mri/excludes/TestRefinement.rb

@@ -10,3 +10,4 @@
 exclude :test_unbound_refine_method, "needs investigation"
 exclude :test_ancestors, "[ruby-core:86949] [Bug #14744]."
 exclude :test_import_methods, "NoMethodError: undefined method `bar' for #<TestRefinement::TestImport::A:0x17bee78>"
+exclude :test_refinements, "TruffleRuby does not guarantee refinement list ordering"

test/mri/tests/ruby/test_refinement.rb

@@ -1835,6 +1835,21 @@ def test_used_modules
     assert_equal [ref::RefB, ref::RefA], ref::Combined::USED_MODS
   end
 
+  def test_refinements
+    int_refinement = nil
+    str_refinement = nil
+    m = Module.new {
+      refine Integer do
+        int_refinement = self
+      end
+
+      refine String do
+        str_refinement = self
+      end
+    }
+    assert_equal([int_refinement, str_refinement], m.refinements)
+  end
+
   def test_warn_setconst_in_refinmenet
     bug10103 = '[ruby-core:64143] [Bug #10103]'
     warnings = [