[GR-20380] Make final fields of CoreLibrary public and remove getters.

PullRequest: truffleruby/1224

Author: eregon

src/main/java/org/truffleruby/RubyContext.java

@@ -202,8 +202,8 @@ public RubyContext(RubyLanguage language, TruffleLanguage.Env env) {
         valueWrapperManager = new ValueWrapperManager(this);
         Metrics.printTime("after-create-core-library");
 
-        symbolTable = new SymbolTable(ropeCache, coreLibrary.getSymbolFactory(), this);
-        rootLexicalScope = new LexicalScope(null, coreLibrary.getObjectClass());
+        symbolTable = new SymbolTable(ropeCache, coreLibrary.symbolFactory, this);
+        rootLexicalScope = new LexicalScope(null, coreLibrary.objectClass);
 
         // Create objects that need core classes
 
@@ -304,7 +304,7 @@ protected boolean patch(Env newEnv) {
 
         Metrics.printTime("before-run-delayed-initialization");
         final Object toRunAtInit = Layouts.MODULE
-                .getFields(coreLibrary.getTruffleBootModule())
+                .getFields(coreLibrary.truffleBootModule)
                 .getConstant("TO_RUN_AT_INIT")
                 .getValue();
         for (Object proc : ArrayOperations.toIterable((DynamicObject) toRunAtInit)) {

src/main/java/org/truffleruby/RubyLanguage.java

@@ -176,7 +176,7 @@ protected Object findExportedSymbol(RubyContext context, String symbolName, bool
         }
 
         Object implicit = context.send(
-                context.getCoreLibrary().getTruffleInteropModule(),
+                context.getCoreLibrary().truffleInteropModule,
                 "lookup_symbol",
                 context.getSymbolTable().getSymbol(symbolName));
         if (implicit == NotProvided.INSTANCE) {
@@ -277,7 +277,7 @@ protected Iterable<Scope> findLocalScopes(RubyContext context, Node node, Frame
 
     @Override
     protected Iterable<Scope> findTopScopes(RubyContext context) {
-        return Collections.singletonList(GlobalScope.getGlobalScope(context.getCoreLibrary().getGlobalVariables()));
+        return Collections.singletonList(GlobalScope.getGlobalScope(context.getCoreLibrary().globalVariables));
     }
 
     public String getTruffleLanguageHome() {

src/main/java/org/truffleruby/builtins/CoreMethodNodeManager.java

@@ -107,9 +107,9 @@ private DynamicObject getModule(String fullName, boolean isClass) {
         DynamicObject module;
 
         if (fullName.equals("main")) {
-            module = getSingletonClass(context.getCoreLibrary().getMainObject());
+            module = getSingletonClass(context.getCoreLibrary().mainObject);
         } else {
-            module = context.getCoreLibrary().getObjectClass();
+            module = context.getCoreLibrary().objectClass;
 
             for (String moduleName : fullName.split("::")) {
                 final ConstantLookupResult constant = ModuleOperations.lookupConstant(context, module, moduleName);
@@ -232,7 +232,7 @@ private static void addMethod(RubyContext context, DynamicObject module,
     private static SharedMethodInfo makeSharedMethodInfo(RubyContext context, LexicalScope lexicalScope,
             DynamicObject module, String name, Arity arity) {
         return new SharedMethodInfo(
-                context.getCoreLibrary().getSourceSection(),
+                context.getCoreLibrary().sourceSection,
                 lexicalScope,
                 arity,
                 module,

src/main/java/org/truffleruby/builtins/EnumeratorSizeNode.java

@@ -46,7 +46,7 @@ public Object execute(VirtualFrame frame) {
 
             final Object self = RubyArguments.getSelf(frame);
             return toEnumWithSize.call(
-                    coreLibrary().getTruffleKernelOperationsModule(),
+                    coreLibrary().truffleKernelOperationsModule,
                     "to_enum_with_size",
                     self,
                     methodName,

src/main/java/org/truffleruby/cext/CExtNodes.java

@@ -1033,7 +1033,7 @@ protected DynamicObject toNative(DynamicObject string,
             final NativeRope nativeRope = stringToNativeNode.executeToNative(string);
 
             return allocateObjectNode
-                    .allocate(coreLibrary().getTruffleFFIPointerClass(), nativeRope.getNativePointer());
+                    .allocate(coreLibrary().truffleFFIPointerClass, nativeRope.getNativePointer());
         }
 
     }
@@ -1102,7 +1102,7 @@ protected DynamicObject classNew(DynamicObject superclass) {
             }
 
             DynamicObject klass = (DynamicObject) allocateNode
-                    .call(getContext().getCoreLibrary().getClassClass(), "__allocate__");
+                    .call(getContext().getCoreLibrary().classClass, "__allocate__");
             return initializeClassNode.executeInitialize(klass, superclass, NotProvided.INSTANCE);
         }
 

src/main/java/org/truffleruby/cext/UnwrapNode.java

@@ -70,7 +70,7 @@ protected NotProvided unwrapUndef(long handle) {
         @Specialization(guards = "handle == NIL_HANDLE")
         protected DynamicObject unwrapNil(long handle,
                 @CachedContext(RubyLanguage.class) RubyContext context) {
-            return context.getCoreLibrary().getNil();
+            return context.getCoreLibrary().nil;
         }
 
         @Specialization(guards = "isTaggedLong(handle)")
@@ -132,7 +132,7 @@ protected ValueWrapper unwrapUndef(long handle) {
         @Specialization(guards = "handle == NIL_HANDLE")
         protected ValueWrapper unwrapNil(long handle,
                 @CachedContext(RubyLanguage.class) RubyContext context) {
-            return new ValueWrapper(context.getCoreLibrary().getNil(), NIL_HANDLE, null);
+            return new ValueWrapper(context.getCoreLibrary().nil, NIL_HANDLE, null);
         }
 
         @Specialization(guards = "isTaggedLong(handle)")

src/main/java/org/truffleruby/cext/ValueWrapperManager.java

@@ -65,7 +65,7 @@ public class ValueWrapperManager {
     public ValueWrapperManager(RubyContext context) {
         this.context = context;
         this.threadBlocks = ThreadLocal.withInitial((this::makeThreadData));
-        nilWrapper = new ValueWrapper(context.getCoreLibrary().getNil(), NIL_HANDLE, null);
+        nilWrapper = new ValueWrapper(context.getCoreLibrary().nil, NIL_HANDLE, null);
     }
 
     public HandleThreadData makeThreadData() {