Align internal and external encoding option names with the standard Ruby option names

Author: eregon

src/launcher/java/org/truffleruby/launcher/RubyLauncher.java

@@ -158,7 +158,6 @@ protected void collectArguments(Set<String> options) {
                 "-x",
                 "--copyright",
                 "--enable", "--disable",
-                "--external-encoding", "--internal-encoding",
                 "--version"));
     }
 

src/main/java/org/truffleruby/options/Options.java

@@ -303,9 +303,9 @@ public Object fromDescription(OptionDescription<?> description) {
                 return VERBOSITY;
             case "ruby.source_encoding":
                 return SOURCE_ENCODING;
-            case "ruby.internal_encoding":
+            case "ruby.internal-encoding":
                 return INTERNAL_ENCODING;
-            case "ruby.external_encoding":
+            case "ruby.external-encoding":
                 return EXTERNAL_ENCODING;
             case "ruby.home":
                 return HOME;

src/shared/java/org/truffleruby/shared/options/OptionsCatalog.java

@@ -56,13 +56,13 @@ public class OptionsCatalog {
             "");
     public static final StringOptionDescription INTERNAL_ENCODING = new StringOptionDescription(
             OptionCategory.USER,
-            "ruby.internal_encoding",
+            "ruby.internal-encoding",
             "Internal encoding (configured by the -E, -U Ruby options)",
             new String[]{"-E", "-U"},
             "");
     public static final StringOptionDescription EXTERNAL_ENCODING = new StringOptionDescription(
             OptionCategory.USER,
-            "ruby.external_encoding",
+            "ruby.external-encoding",
             "External encoding (configured by the -E Ruby option)",
             new String[]{"-E"},
             "");
@@ -813,9 +813,9 @@ public static OptionDescription<?> fromName(String name) {
                 return VERBOSITY;
             case "ruby.source_encoding":
                 return SOURCE_ENCODING;
-            case "ruby.internal_encoding":
+            case "ruby.internal-encoding":
                 return INTERNAL_ENCODING;
-            case "ruby.external_encoding":
+            case "ruby.external-encoding":
                 return EXTERNAL_ENCODING;
             case "ruby.home":
                 return HOME;

tool/options.yml

@@ -7,8 +7,8 @@ USER:
   VERBOSITY: [[verbosity, -v, -w, -W, --verbose], enum/verbosity, false, Verbosity]
 
   SOURCE_ENCODING: [[source_encoding, -K], string, '', Source encoding]
-  INTERNAL_ENCODING: [[internal_encoding, -E, -U], string, '', Internal encoding]
-  EXTERNAL_ENCODING: [[external_encoding, -E], string, '', External encoding]
+  INTERNAL_ENCODING: [[internal-encoding, -E, -U], string, '', Internal encoding]
+  EXTERNAL_ENCODING: [[external-encoding, -E], string, '', External encoding]
 
 EXPERT:
   # Setting home and launcher, useful for embedding