[GR-45620] Apply rubocop-truffleruby to lib/truffle as well

PullRequest: truffleruby/3781

Author: eregon

.rubocop.yml

@@ -12,6 +12,7 @@ AllCops:
   Exclude:
     - 'lib/truffle/date/format.rb' # crashes Rubocop in VariableForce
     - 'lib/truffle/date/delta/parser.rb' # generated code
+    - 'lib/truffle/pathname.rb' # from upstream and should be upstreamed
     - 'lib/truffle/socket/mri.rb' # taken from MRI
     - 'lib/truffle/ffi/**/*.rb' # taken from FFI gem
     - 'src/main/ruby/truffleruby/core/truffle/ffi/pointer_extra.rb' # taken from FFI gem
@@ -400,23 +401,27 @@ Layout/SpaceAroundEqualsInParameterDefault:
 # Supports --auto-correct
 TruffleRuby/ReplaceWithPrimitiveNil:
   Enabled: true
-  Include: # inspect *only* this directory
+  Include: # inspect *only* these files
+    - lib/truffle/**/*.rb
     - src/main/ruby/**/*.rb
 
 # Supports --auto-correct
 TruffleRuby/ReplaceWithPrimitiveObjectClass:
   Enabled: true
-  Include: # inspect *only* this directory
+  Include: # inspect *only* these files
+    - lib/truffle/**/*.rb
     - src/main/ruby/**/*.rb
 
 # Supports --auto-correct
 TruffleRuby/ReplaceWithPrimitiveObjectEqual:
   Enabled: true
-  Include: # inspect *only* this directory
+  Include: # inspect *only* these files
+    - lib/truffle/**/*.rb
     - src/main/ruby/**/*.rb
 
 # Supports --auto-correct
 TruffleRuby/ReplaceWithPrimitiveObjectKindOf:
   Enabled: true
-  Include: # inspect *only* this directory
+  Include: # inspect *only* these files
+    - lib/truffle/**/*.rb
     - src/main/ruby/**/*.rb

lib/cext/ABI_check.txt

@@ -1 +1 @@
-5
+6

lib/truffle/continuation.rb

@@ -1,3 +1,5 @@
+# truffleruby_primitives: true
+
 # Copyright (c) 2017, 2023 Oracle and/or its affiliates. All rights reserved. This
 # code is released under a tri EPL/GPL/LGPL license. You can use it,
 # redistribute it and/or modify it under the terms of the:

lib/truffle/coverage.rb

@@ -1,3 +1,5 @@
+# truffleruby_primitives: true
+
 # Copyright (c) 2015, 2023 Oracle and/or its affiliates. All rights reserved. This
 # code is released under a tri EPL/GPL/LGPL license. You can use it,
 # redistribute it and/or modify it under the terms of the:

lib/truffle/digest.rb

@@ -83,16 +83,16 @@ def new
     end
 
     def block_length
-      raise RuntimeError, "#{self.class.name} does not implement block_length()"
+      raise RuntimeError, "#{Primitive.class(self).name} does not implement block_length()"
     end
 
     def update(message)
-      raise RuntimeError, "#{self.class.name} does not implement update()"
+      raise RuntimeError, "#{Primitive.class(self).name} does not implement update()"
     end
     alias_method :<<, :update
 
     def reset
-      raise RuntimeError, "#{self.class.name} does not implement reset()"
+      raise RuntimeError, "#{Primitive.class(self).name} does not implement reset()"
     end
 
     def digest(message = NO_MESSAGE)
@@ -150,7 +150,7 @@ def ==(other)
     end
 
     def inspect
-      "#<#{self.class.name}: #{hexdigest}>"
+      "#<#{Primitive.class(self).name}: #{hexdigest}>"
     end
   end
 

lib/truffle/digest/bubblebabble.rb

@@ -1,3 +1,5 @@
+# truffleruby_primitives: true
+
 # Copyright (c) 2015, 2023 Oracle and/or its affiliates. All rights reserved. This
 # code is released under a tri EPL/GPL/LGPL license. You can use it,
 # redistribute it and/or modify it under the terms of the:

lib/truffle/fcntl.rb

@@ -1,3 +1,5 @@
+# truffleruby_primitives: true
+
 # Copyright (c) 2015, 2023 Oracle and/or its affiliates. All rights reserved. This
 # code is released under a tri EPL/GPL/LGPL license. You can use it,
 # redistribute it and/or modify it under the terms of the:

lib/truffle/ffi.rb

@@ -1,3 +1,5 @@
+# truffleruby_primitives: true
+
 # Copyright (c) 2017, 2019 Oracle and/or its affiliates. All rights reserved. This
 # code is released under a tri EPL/GPL/LGPL license. You can use it,
 # redistribute it and/or modify it under the terms of the:

lib/truffle/objspace.rb

@@ -14,7 +14,7 @@ def self.count_nodes_method(method, nodes)
 
     until node_stack.empty?
       node = node_stack.pop
-      next if node.nil?
+      next if Primitive.nil?(node)
 
       name = node.first
       children = node.drop(1)

lib/truffle/pathname.rb

@@ -1,5 +1,5 @@
 # truffleruby_primitives: true
-#
+
 # = pathname.rb
 #
 # Object-Oriented Pathname Class