Refactor TimeOperations.compose and simplify code a bit

Author: andrykonchin

src/main/java/org/truffleruby/core/time/TimeNodes.java

@@ -511,6 +511,7 @@ public abstract static class TimeSFromArrayPrimitiveNode extends PrimitiveArrayA
         @Child private TruffleString.FromJavaStringNode fromJavaStringNode;
 
         @Specialization(guards = "(isutc || !isRubyDynamicObject(utcoffset)) || isNil(utcoffset)")
+        @TruffleBoundary
         protected RubyTime timeSFromArray(
                 RubyClass timeClass,
                 int sec,
@@ -524,13 +525,7 @@ protected RubyTime timeSFromArray(
                 boolean isutc,
                 Object utcoffset) {
             final RubyLanguage language = getLanguage();
-            return buildTime(language, timeClass, sec, min, hour, mday, month, year, nsec, isdst, isutc, utcoffset);
-        }
 
-        @TruffleBoundary
-        private RubyTime buildTime(RubyLanguage language, RubyClass timeClass, int sec, int min, int hour, int mday,
-                int month,
-                int year, int nsec, int isdst, boolean isutc, Object utcoffset) {
             if (nsec < 0 || nsec > 999999999 ||
                     sec < 0 || sec > 60 || // MRI accepts sec=60, whether it is a leap second or not
                     min < 0 || min > 59 ||

src/main/ruby/truffleruby/core/truffle/time_operations.rb

@@ -15,45 +15,40 @@ module TimeOperations
       'JUL' => 7, 'AUG' => 8, 'SEP' => 9, 'OCT' =>10, 'NOV' =>11, 'DEC' =>12
     }
 
+    # Handles Time methods .utc, .gm. .local, .mktime dual signature:
+    # - year, month, day, hour, min, sec, usec
+    # - sec, min, hour, day, month, year
     def self.compose(time_class, utc_offset, p1, p2 = nil, p3 = nil, p4 = nil, p5 = nil, p6 = nil, p7 = nil,
                 yday = undefined, is_dst = undefined, tz = undefined)
       if Primitive.undefined?(tz)
         unless Primitive.undefined?(is_dst)
           raise ArgumentError, 'wrong number of arguments (9 for 1..8)'
         end
 
-        year = p1
-        month = p2
-        mday = p3
-        hour = p4
-        min = p5
-        sec = p6
-        usec = p7
-        is_dst = -1
+        year, month, mday, hour, min, sec, usec, is_dst = p1, p2, p3, p4, p5, p6, p7, -1
       else
-        year = p6
-        month = p5
-        mday = p4
-        hour = p3
-        min = p2
-        sec = p1
-        usec = 0
-        is_dst = is_dst ? 1 : 0
+        year, month, mday, hour, min, sec, usec, is_dst = p6, p5, p4, p3, p2, p1, 0, is_dst ? 1 : 0
       end
 
       if Primitive.is_a?(month, String) or month.respond_to?(:to_str)
         month = StringValue(month)
         month = MonthValue[month.upcase] || month.to_i
 
         raise ArgumentError, 'month argument out of range' unless month
-      else
-        month = Truffle::Type.coerce_to(month || 1, Integer, :to_int)
       end
 
-      year = Primitive.is_a?(year, String)  ? year.to_i : Truffle::Type.coerce_to(year,       Integer, :to_int)
-      mday = Primitive.is_a?(mday, String)  ? mday.to_i : Truffle::Type.coerce_to(mday  || 1, Integer, :to_int)
-      hour = Primitive.is_a?(hour, String)  ? hour.to_i : Truffle::Type.coerce_to(hour  || 0, Integer, :to_int)
-      min  = Primitive.is_a?(min,  String)  ? min.to_i  : Truffle::Type.coerce_to(min   || 0, Integer, :to_int)
+      year = year.to_i if Primitive.is_a?(year, String)
+      mday = mday.to_i if Primitive.is_a?(mday, String)
+      hour = hour.to_i if Primitive.is_a?(hour, String)
+      min  = min.to_i  if Primitive.is_a?(min,  String)
+
+      # Ensure all the user provided numeric values fit into the Java Integer type.
+      # sec and nsec are handled separately.
+      year  = Primitive.rb_num2int(year      )
+      month = Primitive.rb_num2int(month || 1)
+      mday  = Primitive.rb_num2int(mday  || 1)
+      hour  = Primitive.rb_num2int(hour  || 0)
+      min   = Primitive.rb_num2int(min   || 0)
 
       nsec = nil
       if Primitive.is_a?(usec, String)
@@ -75,15 +70,6 @@ def self.compose(time_class, utc_offset, p1, p2 = nil, p3 = nil, p4 = nil, p5 =
         is_utc = false
       end
 
-      # Ensure all the user provided numeric values fit into the Java Integer type.
-      # sec and nsec are handled separately.
-      Primitive.rb_num2int(min)
-      Primitive.rb_num2int(hour)
-      Primitive.rb_num2int(mday)
-      Primitive.rb_num2int(month)
-      Primitive.rb_num2int(year)
-
-      # handle sec and nsec
       if Primitive.is_a?(sec, String)
         sec = sec.to_i
       elsif nsec