[GR-19220] Add spec for small Rational passed to Time::at (#2288)

PullRequest: truffleruby/2480

Author: eregon

spec/ruby/core/time/at_spec.rb

@@ -38,6 +38,20 @@
         Time.at(BigDecimal('1.1')).to_f.should == 1.1
       end
     end
+
+    describe "passed Rational" do
+      it "returns Time with correct microseconds" do
+        t = Time.at(Rational(1_486_570_508_539_759, 1_000_000))
+        t.usec.should == 539_759
+        t.nsec.should == 539_759_000
+      end
+
+      it "returns Time with correct nanoseconds" do
+        t = Time.at(Rational(1_486_570_508_539_759_123, 1_000_000_000))
+        t.usec.should == 539_759
+        t.nsec.should == 539_759_123
+      end
+    end
   end
 
   describe "passed Time" do

src/main/ruby/truffleruby/core/time.rb

@@ -300,11 +300,11 @@ def _dump(limit = nil)
   private :_dump
 
   class << self
-    def at(sec, usec=undefined, unit=undefined, **kwargs)
+    def at(sec, sub_sec=undefined, unit=undefined, **kwargs)
       # **kwargs is used here because 'in' is a ruby keyword
       offset = kwargs[:in] ? Truffle::Type.coerce_to_utc_offset(kwargs[:in]) : nil
 
-      result = if Primitive.undefined?(usec)
+      result = if Primitive.undefined?(sub_sec)
                  if Primitive.object_kind_of?(sec, Time)
                    copy = allocate
                    copy.send(:initialize_copy, sec)
@@ -321,11 +321,11 @@ def at(sec, usec=undefined, unit=undefined, **kwargs)
         return result
       end
 
-      if Primitive.object_kind_of?(sec, Time) && Primitive.object_kind_of?(usec, Integer)
+      if Primitive.object_kind_of?(sec, Time) && Primitive.object_kind_of?(sub_sec, Integer)
         raise TypeError, "can't convert Time into an exact number"
       end
 
-      second_arg_scale =
+      sub_sec_scale =
         if Primitive.undefined?(unit) || :microsecond == unit || :usec == unit
           1_000
         elsif :millisecond == unit
@@ -336,21 +336,17 @@ def at(sec, usec=undefined, unit=undefined, **kwargs)
           raise ArgumentError, "unexpected unit: #{unit}"
         end
 
-      usec = 0 if Primitive.undefined?(usec)
+      sec = Truffle::Type.coerce_to_exact_num(sec)
+      sub_sec = Primitive.undefined?(sub_sec) ? 0 : Truffle::Type.coerce_to_exact_num(sub_sec)
 
-      s = Truffle::Type.coerce_to_exact_num(sec)
-      u = Truffle::Type.coerce_to_exact_num(usec)
+      seconds, sec_frac = sec.divmod(1)
 
-      sec = s.to_i
-      nsec_frac = s % 1.0
+      nsec = (sec_frac * 1_000_000_000).round + (sub_sec * sub_sec_scale).to_i
 
-      sec -= 1 if s < 0 && nsec_frac > 0
-      nsec = (nsec_frac * 1_000_000_000 + 0.5).to_i + (u * second_arg_scale).to_i
-
-      sec += nsec / 1_000_000_000
+      seconds += nsec / 1_000_000_000
       nsec %= 1_000_000_000
 
-      time = Primitive.time_at self, sec, nsec
+      time = Primitive.time_at self, seconds, nsec
       time = Primitive.time_localtime(time, offset) if offset
       time
     end