Skip to content

Commit 4705dfd

Browse files
author
Nicolas Laurent
committed
minor style/comment fixes
1 parent 80c9267 commit 4705dfd

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

src/main/java/org/truffleruby/language/FrameSendingNode.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
* <p>
3939
* Materializing a frame is expensive, and the point of this parent node is to only materialize the frame when we know
4040
* for sure it has been requested by the callee. It is also possible to walk the stack to retrieve the frame to
41-
* materialize - but this is even slower and causes a deoptimization in the callee.
41+
* materialize - but this is even slower and causes a deoptimization in the callee every time we walk the stack.
4242
*
4343
* <p>
4444
* This class works in tandem with {@link ReadCallerFrameNode} for this purpose. At first, we don't send down the frame.

src/main/java/org/truffleruby/language/dispatch/DispatchNode.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public static DispatchNode create() {
6565
}
6666

6767
public static DispatchNode getUncached(DispatchConfiguration config) {
68-
return Uncached.uncachedNodes[config.ordinal()];
68+
return Uncached.UNCACHED_NODES[config.ordinal()];
6969
}
7070

7171
public static DispatchNode getUncached() {
@@ -260,10 +260,10 @@ public final void applySplittingInliningStrategy(InternalMethod method, DirectCa
260260

261261
private static class Uncached extends DispatchNode {
262262

263-
static final Uncached[] uncachedNodes = new Uncached[DispatchConfiguration.values().length];
263+
static final Uncached[] UNCACHED_NODES = new Uncached[DispatchConfiguration.values().length];
264264
static {
265265
for (DispatchConfiguration config : DispatchConfiguration.values()) {
266-
uncachedNodes[config.ordinal()] = new Uncached(config);
266+
UNCACHED_NODES[config.ordinal()] = new Uncached(config);
267267
}
268268
}
269269

src/main/java/org/truffleruby/language/dispatch/RubyCallNode.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public class RubyCallNode extends RubyContextSourceNode {
5353
private final boolean isSafeNavigation;
5454
private final boolean isAttrAssign;
5555

56-
@Child private DispatchNode dispatchHead;
56+
@Child private DispatchNode dispatch;
5757
@Child private ArrayToObjectArrayNode toObjectArrayNode;
5858
@Child private DefinedNode definedNode;
5959

@@ -112,12 +112,12 @@ public Object execute(VirtualFrame frame) {
112112

113113
public Object executeWithArgumentsEvaluated(VirtualFrame frame, Object receiverObject, RubyProc blockObject,
114114
Object[] argumentsObjects) {
115-
if (dispatchHead == null) {
115+
if (dispatch == null) {
116116
CompilerDirectives.transferToInterpreterAndInvalidate();
117-
dispatchHead = insert(DispatchNode.create(ignoreVisibility ? PRIVATE : PROTECTED));
117+
dispatch = insert(DispatchNode.create(ignoreVisibility ? PRIVATE : PROTECTED));
118118
}
119119

120-
final Object returnValue = dispatchHead
120+
final Object returnValue = dispatch
121121
.dispatch(frame, receiverObject, methodName, blockObject, argumentsObjects);
122122
if (isAttrAssign) {
123123
return argumentsObjects[argumentsObjects.length - 1];

0 commit comments

Comments
 (0)