Fix the exception type raised when type coercion via to_sym raises a NoMethodError.

Author: nirvdrum

spec/ruby/core/module/alias_method_spec.rb

@@ -81,6 +81,12 @@ def uno_refined_method
     -> { @class.make_alias mock('x'), :public_one }.should raise_error(TypeError)
   end
 
+  it "raises a NoMethodError if the given name raises a NoMethodError during type coercion using to_str" do
+    obj = mock("mock-name")
+    obj.should_receive(:to_str).and_raise(NoMethodError)
+    -> { @class.make_alias obj, :public_one }.should raise_error(NoMethodError)
+  end
+
   it "is a public method" do
     Module.should have_public_instance_method(:alias_method, false)
   end

src/main/java/org/truffleruby/core/cast/ToSymbolNode.java

@@ -24,7 +24,6 @@
 import org.truffleruby.language.control.RaiseException;
 import org.truffleruby.language.dispatch.DispatchNode;
 import org.truffleruby.language.library.RubyStringLibrary;
-import org.truffleruby.utils.Utils;
 
 @GenerateUncached
 @NodeChild(value = "valueNode", type = RubyBaseNodeWithExecute.class)
@@ -85,22 +84,15 @@ protected RubySymbol rubyStringUncached(Object str,
     @Specialization(guards = { "!isRubySymbol(object)", "!isString(object)", "isNotRubyString(object)" })
     protected RubySymbol toStr(Object object,
             @Cached BranchProfile errorProfile,
-            @Cached DispatchNode toStr,
+            @Cached DispatchNode toStrNode,
             @Cached RubyStringLibrary libString,
             @Cached ToSymbolNode toSymbolNode) {
-        final Object coerced;
-        try {
-            coerced = toStr.call(object, "to_str");
-        } catch (RaiseException e) {
-            errorProfile.enter();
-            if (e.getException().getLogicalClass() == coreLibrary().noMethodErrorClass) {
-                throw new RaiseException(getContext(), coreExceptions().typeError(
-                        Utils.concat(object, " is not a symbol nor a string"),
-                        this));
-            } else {
-                throw e;
-            }
-        }
+        var coerced = toStrNode.call(
+                coreLibrary().truffleTypeModule,
+                "rb_convert_type",
+                object,
+                coreLibrary().stringClass,
+                coreSymbols().TO_STR);
 
         if (libString.isRubyString(coerced)) {
             return toSymbolNode.execute(coerced);