Skip to content

Commit 4083291

Browse files
committed
Refactor ReadStringNode and ReadStringOrDefaultValueNode to not instantiate not needed object to instantiate ToStringNode
1 parent ccb4e57 commit 4083291

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/main/java/org/truffleruby/core/format/read/array/ReadStringNode.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,9 @@
1212
import org.truffleruby.core.array.ArrayGuards;
1313
import org.truffleruby.core.array.library.ArrayStoreLibrary;
1414
import org.truffleruby.core.format.FormatNode;
15-
import org.truffleruby.core.format.LiteralFormatNode;
1615
import org.truffleruby.core.format.convert.ToStringNode;
1716
import org.truffleruby.core.format.convert.ToStringNodeGen;
1817
import org.truffleruby.core.format.read.SourceNode;
19-
import org.truffleruby.core.format.write.bytes.WriteByteNodeGen;
2018

2119
import com.oracle.truffle.api.CompilerDirectives;
2220
import com.oracle.truffle.api.dsl.ImportStatic;
@@ -68,7 +66,7 @@ private Object readAndConvert(Object value) {
6866
conversionMethod,
6967
inspectOnConversionFailure,
7068
specialClassBehaviour,
71-
WriteByteNodeGen.create(new LiteralFormatNode((byte) 0))));
69+
null));
7270
}
7371

7472
return toStringNode.executeToString(value);

src/main/java/org/truffleruby/core/format/read/array/ReadStringOrDefaultValueNode.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,9 @@
1212
import org.truffleruby.core.array.ArrayGuards;
1313
import org.truffleruby.core.array.library.ArrayStoreLibrary;
1414
import org.truffleruby.core.format.FormatNode;
15-
import org.truffleruby.core.format.LiteralFormatNode;
1615
import org.truffleruby.core.format.convert.ToStringOrDefaultValueNode;
1716
import org.truffleruby.core.format.convert.ToStringOrDefaultValueNodeGen;
1817
import org.truffleruby.core.format.read.SourceNode;
19-
import org.truffleruby.core.format.write.bytes.WriteByteNodeGen;
2018

2119
import com.oracle.truffle.api.CompilerDirectives;
2220
import com.oracle.truffle.api.dsl.ImportStatic;
@@ -73,7 +71,7 @@ private Object readAndConvert(Object value) {
7371
inspectOnConversionFailure,
7472
valueOnNil,
7573
specialClassBehaviour,
76-
WriteByteNodeGen.create(new LiteralFormatNode((byte) 0))));
74+
null));
7775
}
7876

7977
return toStringOrDefaultValueNode.executeToString(value);

0 commit comments

Comments
 (0)