Allow Time#strftime to be called with binary format strings.

Author: nirvdrum

CHANGELOG.md

@@ -3,6 +3,7 @@
 Bug fixes:
 
 * Fixed `Symbol#match` returning `MatchData` (#1706).
+* Allow `Time#strftime` to be called with binary format strings.
 
 Compatibility:
 

src/main/java/org/truffleruby/core/time/RubyDateFormatter.java

@@ -45,7 +45,6 @@
 import org.jcodings.Encoding;
 import org.jcodings.specific.ASCIIEncoding;
 import org.truffleruby.RubyContext;
-import org.truffleruby.core.encoding.EncodingManager;
 import org.truffleruby.core.rope.Rope;
 import org.truffleruby.core.rope.RopeBuilder;
 import org.truffleruby.core.rope.RopeOperations;
@@ -522,7 +521,7 @@ public static RopeBuilder formatToRopeBuilder(List<Token> compiledPattern, Zoned
             // reset formatter
             formatter = RubyTimeOutputFormatter.DEFAULT_FORMATTER;
 
-            toAppendTo.append(output.getBytes(EncodingManager.charsetForEncoding(toAppendTo.getEncoding())));
+            toAppendTo.append(StringOperations.encodeBytes(output, toAppendTo.getEncoding()));
         }
 
         return toAppendTo;

test/mri/excludes/TestTimeExtension.rb

@@ -1,38 +1,5 @@
-exclude :test_completion, "needs investigation"
-exclude :test_completion_with_different_timezone, "needs investigation"
-exclude :test_encode_httpdate, "needs investigation"
-exclude :test_encode_rfc2822, "needs investigation"
-exclude :test_encode_xmlschema, "needs investigation"
-exclude :test_huge_precision, "needs investigation"
-exclude :test_invalid, "needs investigation"
-exclude :test_nsec, "needs investigation"
-exclude :test_parse_fraction, "needs investigation"
-exclude :test_parse_leap_second, "needs investigation"
-exclude :test_rfc2616, "needs investigation"
-exclude :test_rfc2822, "needs investigation"
-exclude :test_rfc2822_leap_second, "needs investigation"
-exclude :test_rfc2822_utc_roundtrip_summer, "needs investigation"
-exclude :test_rfc2822_utc_roundtrip_winter, "needs investigation"
-exclude :test_rfc3339, "needs investigation"
-exclude :test_rfc822, "needs investigation"
-exclude :test_ruby_talk_152866, "needs investigation"
-exclude :test_strptime, "needs investigation"
-exclude :test_strptime_Ymd_z, "needs investigation"
-exclude :test_strptime_empty, "needs investigation"
-exclude :test_strptime_s_z, "needs investigation"
-exclude :test_xmlschema, "needs investigation"
-exclude :test_xmlschema_fraction, "needs investigation"
-exclude :test_xmlschema_leap_second, "needs investigation"
-exclude :test_zone_0000, "needs investigation"
-exclude :test_iso8601, "needs investigation"
-exclude :test_iso8601_alias, "needs investigation"
 exclude :test_iso8601_encode, "needs investigation"
-exclude :test_iso8601_nsec, "needs investigation"
 exclude :test_strptime_s_N, "needs investigation"
-exclude :test_xmlschema_alias, "needs investigation"
 exclude :test_xmlschema_encode, "needs investigation"
-exclude :test_xmlschema_nsec, "needs investigation"
-exclude :test_iso8601_leap_second, "needs investigation"
-exclude :test_parse_offset_hour_minute_second, "needs investigation"
-exclude :test_strptime_j, "needs investigation"
-exclude :test_parse_with_various_object, "needs investigation"
+exclude :test_iso8601, "needs investigation"
+exclude :test_xmlschema, "needs investigation"