[GR-17457] Fix FreezeNode is synchronizing on object and not node

horakivo · horakivo · commit 3e9d8d85e651 · 2023-06-02T12:08:12.000Z
PullRequest: truffleruby/3850
diff --git a/src/main/java/org/truffleruby/language/objects/FreezeNode.java b/src/main/java/org/truffleruby/language/objects/FreezeNode.java
@@ -37,7 +37,7 @@ protected Object freezeRubyString(RubyString object) {
     protected Object freeze(RubyDynamicObject object,
             @CachedLibrary("object") DynamicObjectLibrary objectLibrary) {
         if (objectLibrary.isShared(object)) {
-            synchronized (this) {
+            synchronized (object) {
                 objectLibrary.setShapeFlags(object, objectLibrary.getShapeFlags(object) | FROZEN_FLAG);
             }
         } else {

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ protected Object freezeRubyString(RubyString object) {`
`37`	`37`	`protected Object freeze(RubyDynamicObject object,`
`38`	`38`	`@CachedLibrary("object") DynamicObjectLibrary objectLibrary) {`
`39`	`39`	`if (objectLibrary.isShared(object)) {`
`40`		`- synchronized (this) {`
	`40`	`+ synchronized (object) {`
`41`	`41`	`objectLibrary.setShapeFlags(object, objectLibrary.getShapeFlags(object) \| FROZEN_FLAG);`
`42`	`42`	`}`
`43`	`43`	`} else {`