[GR-18163] Convert objects with #to_path in $LOAD_PATH (#2119)

PullRequest: truffleruby/2059

Author: eregon

CHANGELOG.md

@@ -46,6 +46,7 @@ Compatibility:
 * Module#using raises error in method scope (#2112, @ssnickolay)
 * `File#path` now returns a new mutable String on every call like MRI (#2115).
 * Avoid infinite recursion when redefining `Warning#warn` and calling `Kernel#warn` (#2109).
+* Convert objects with `#to_path` in `$LOAD_PATH` (#2119).
 
 Performance:
 

spec/ruby/core/kernel/shared/require.rb

@@ -160,6 +160,14 @@
       ScratchPad.recorded.should == [:loaded]
     end
 
+    it "accepts an Object with #to_path in $LOAD_PATH" do
+      obj = mock("to_path")
+      obj.should_receive(:to_path).at_least(:once).and_return(CODE_LOADING_DIR)
+      $LOAD_PATH << obj
+      @object.send(@method, "load_fixture.rb").should be_true
+      ScratchPad.recorded.should == [:loaded]
+    end
+
     it "does not require file twice after $LOAD_PATH change" do
       $LOAD_PATH << CODE_LOADING_DIR
       @object.require("load_fixture.rb").should be_true

src/main/ruby/truffleruby/core/truffle/feature_loader.rb

@@ -279,7 +279,7 @@ def self.features_index_add(feature, offset)
 
     def self.get_expanded_load_path
       unless Primitive.array_storage_equal?(@load_path_copy, $LOAD_PATH)
-        @expanded_load_path = $LOAD_PATH.map { |path| Primitive.canonicalize_path(path) }
+        @expanded_load_path = $LOAD_PATH.map { |path| Primitive.canonicalize_path(Truffle::Type.coerce_to_path(path)) }
         @loaded_features_copy = $LOAD_PATH.dup
       end
       @expanded_load_path