[GR-18163] Remove Struct.members method in explicitly inherited subclasses

PullRequest: truffleruby/4488

Author: andrykonchin

CHANGELOG.md

@@ -12,6 +12,7 @@ Compatibility:
 * Support String patterns in `StringScanner#{exist?,scan_until,skip_until,check_until,search_full}` methods (@andrykonchin).
 * Implement `ObjectSpace::WeakKeyMap` (#3681, @andrykonchin).
 * Fix `String#slice` called with negative offset (@andrykonchin).
+* Fix explicitly inherited `Struct` subclasses and don't provide `#members` method (#3802, @andrykonchin).
 
 Performance:
 

spec/ruby/core/data/fixtures/classes.rb

@@ -1,5 +1,7 @@
 module DataSpecs
   guard -> { ruby_version_is "3.2" and Data.respond_to?(:define) } do
     Measure = Data.define(:amount, :unit)
+
+    class DataSubclass < Data; end
   end
 end

spec/ruby/core/data/members_spec.rb

@@ -0,0 +1,23 @@
+require_relative '../../spec_helper'
+require_relative 'fixtures/classes'
+
+ruby_version_is "3.2" do
+  describe "Data#members" do
+    it "returns an array of attribute names" do
+      measure = DataSpecs::Measure.new(amount: 42, unit: 'km')
+      measure.members.should == [:amount, :unit]
+    end
+  end
+
+  describe "DataClass#members" do
+    it "returns an array of attribute names" do
+      DataSpecs::Measure.members.should == [:amount, :unit]
+    end
+
+    context "class inheriting Data" do
+      it "isn't available in a subclass" do
+        DataSpecs::DataSubclass.should_not.respond_to?(:members)
+      end
+    end
+  end
+end

spec/ruby/core/process/tms/cstime_spec.rb

@@ -0,0 +1,17 @@
+require_relative '../../../spec_helper'
+
+describe "Process::Tms#cstime" do
+  it "returns cstime attribute" do
+    cstime = Object.new
+    Process::Tms.new(nil, nil, nil, cstime).cstime.should == cstime
+  end
+end
+
+describe "Process::Tms#cstime=" do
+  it "assigns a value to the cstime attribute" do
+    cstime = Object.new
+    tms = Process::Tms.new
+    tms.cstime = cstime
+    tms.cstime.should == cstime
+  end
+end

spec/ruby/core/process/tms/cutime_spec.rb

@@ -0,0 +1,17 @@
+require_relative '../../../spec_helper'
+
+describe "Process::Tms#cutime" do
+  it "returns cutime attribute" do
+    cutime = Object.new
+    Process::Tms.new(nil, nil, cutime, nil).cutime.should == cutime
+  end
+end
+
+describe "Process::Tms#cutime=" do
+  it "assigns a value to the cutime attribute" do
+    cutime = Object.new
+    tms = Process::Tms.new
+    tms.cutime = cutime
+    tms.cutime.should == cutime
+  end
+end

spec/ruby/core/process/tms/stime_spec.rb

@@ -0,0 +1,17 @@
+require_relative '../../../spec_helper'
+
+describe "Process::Tms#stime" do
+  it "returns stime attribute" do
+    stime = Object.new
+    Process::Tms.new(nil, stime, nil, nil).stime.should == stime
+  end
+end
+
+describe "Process::Tms#stime=" do
+  it "assigns a value to the stime attribute" do
+    stime = Object.new
+    tms = Process::Tms.new
+    tms.stime = stime
+    tms.stime.should == stime
+  end
+end

spec/ruby/core/process/tms/utime_spec.rb

@@ -0,0 +1,17 @@
+require_relative '../../../spec_helper'
+
+describe "Process::Tms#utime" do
+  it "returns utime attribute" do
+    utime = Object.new
+    Process::Tms.new(utime, nil, nil, nil).utime.should == utime
+  end
+end
+
+describe "Process::Tms#utime=" do
+  it "assigns a value to the ctime attribute" do
+    utime = Object.new
+    tms = Process::Tms.new
+    tms.utime = utime
+    tms.utime.should == utime
+  end
+end

spec/ruby/core/struct/fixtures/classes.rb

@@ -29,4 +29,6 @@ def initialize(*)
       super
     end
   end
+
+  class StructSubclass < Struct; end
 end

spec/ruby/core/struct/keyword_init_spec.rb

@@ -1,4 +1,5 @@
 require_relative '../../spec_helper'
+require_relative 'fixtures/classes'
 
 ruby_version_is "3.1" do
   # See https://bugs.ruby-lang.org/issues/18008
@@ -36,5 +37,11 @@
       struct = Struct.new(:arg, keyword_init: {})
       struct.keyword_init?.should be_true
     end
+
+    context "class inheriting Struct" do
+      it "isn't available in a subclass" do
+        StructClasses::StructSubclass.should_not.respond_to?(:keyword_init?)
+      end
+    end
   end
 end

spec/ruby/core/struct/members_spec.rb

@@ -11,3 +11,15 @@
 
   it_behaves_like :struct_accessor, :members
 end
+
+describe "StructClass#members" do
+  it "returns an array of attribute names" do
+    StructClasses::Car.members.should == [:make, :model, :year]
+  end
+
+  context "class inheriting Struct" do
+    it "isn't available in a subclass" do
+      StructClasses::StructSubclass.should_not.respond_to?(:members)
+    end
+  end
+end