Skip to content

Commit 3689787

Browse files
committed
Workaround to get grpc to build in macOS
1 parent 43e0571 commit 3689787

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

lib/truffle/rbconfig.rb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,10 @@ module RbConfig
8686
cc = 'clang'
8787
cxx = 'clang++'
8888
ranlib = 'ranlib'
89-
strip = 'strip -A -n'
89+
# We add -x here, `strip -A -n` always fails, like `error: symbols referenced by indirect symbol table entries that can't be stripped` even on CRuby.
90+
# This is notably necessary for grpc where the current logic does not append -x for TruffleRuby:
91+
# https://github.com/grpc/grpc/blob/54f65e0dbd2151a3ba2ad364327c0c31b200a5ae/src/ruby/ext/grpc/extconf.rb#L125-L126
92+
strip = 'strip -A -n -x'
9093
gcc, clang = false, true
9194
cflags_pre = '-fdeclspec '
9295
else

0 commit comments

Comments
 (0)