[GR-15915] Convert to intuitive Ruby exceptions when INVOKE fails.

PullRequest: truffleruby/846

Author: eregon

CHANGELOG.md

@@ -10,6 +10,7 @@ Bug fixes:
 * Fixed `rb_get_kwargs` to correctly handle optional and rest arguments.
 * Calling `Kernel#raise` with a raised exception will no longer set the cause of the exception to itself (#1682).
 * Return a `FFI::Function` correctly for functions returning a callback.
+* Convert to intuitive Ruby exceptions when INVOKE fails (#1690).
 
 Compatibility
 

src/main/java/org/truffleruby/core/exception/CoreExceptions.java

@@ -13,6 +13,7 @@
 
 import java.util.EnumSet;
 
+import com.oracle.truffle.api.interop.InteropException;
 import com.oracle.truffle.api.source.SourceSection;
 import org.jcodings.Encoding;
 import org.jcodings.specific.UTF8Encoding;
@@ -661,8 +662,8 @@ public DynamicObject noSuperMethodOutsideMethodError(Node currentNode) {
                 context.getSymbolTable().getSymbol("<unknown>")));
     }
 
-    public DynamicObject noMethodErrorUnknownIdentifier(TruffleObject receiver, Object name, Object[] args, UnknownIdentifierException exception, Node currentNode) {
-        return noMethodError(exception.getMessage(), receiver, name.toString(), args, currentNode);
+    public DynamicObject noMethodErrorUnknownIdentifier(TruffleObject receiver, String name, Object[] args, InteropException exception, Node currentNode) {
+        return noMethodError(exception.getMessage(), receiver, name, args, currentNode);
     }
 
     // LoadError

src/main/java/org/truffleruby/interop/OutgoingForeignCallNode.java

@@ -488,12 +488,12 @@ public Object executeCall(TruffleObject receiver, Object[] args) {
                         receiver,
                         name,
                         arguments);
-            } catch (UnknownIdentifierException e) {
+            } catch (UnknownIdentifierException | UnsupportedMessageException e) {
                 unknownIdentifierProfile.enter();
                 throw new RaiseException(getContext(), coreExceptions().noMethodErrorUnknownIdentifier(receiver, name, args, e, this));
-            } catch (UnsupportedTypeException | ArityException | UnsupportedMessageException e) {
-                exceptionProfile.enter();
-                throw new JavaException(e);
+            } catch (UnsupportedTypeException | ArityException e) {
+                argumentErrorProfile.enter();
+                throw new RaiseException(getContext(), coreExceptions().argumentError(e.getMessage(), this));
             }
 
             return foreignToRubyNode.executeConvert(foreign);