Make the marking service cache size configuratble.

Author: aardvark179

src/main/java/org/truffleruby/core/MarkingService.java

@@ -79,11 +79,11 @@ public ReferenceProcessingService<MarkerReference> service() {
         }
     }
 
-    private static final int KEPT_COUNT_SIZE = 10_000;
+    private final int cacheSize = context.getOptions().CEXTS_MARKING_CACHE;
 
     private final ThreadLocal<Deque<ArrayList<Object>>> stackPreservation = ThreadLocal.withInitial(() -> new ArrayDeque<>());
 
-    private Object[] keptObjects = new Object[KEPT_COUNT_SIZE];
+    private Object[] keptObjects = new Object[cacheSize];
 
     private int counter = 0;
 
@@ -104,10 +104,10 @@ private synchronized Object[] addToKeptObjects(Object object) {
             keepList.add(object);
         }
         keptObjects[counter++] = object;
-        if (counter == KEPT_COUNT_SIZE) {
+        if (counter == cacheSize) {
             counter = 0;
             Object[] tmp = keptObjects;
-            keptObjects = new Object[KEPT_COUNT_SIZE];
+            keptObjects = new Object[cacheSize];
             return tmp;
         }
         return null;
@@ -123,6 +123,12 @@ public void popStackPreservationFrame() {
         stackPreservation.get().pop();
     }
 
+    public synchronized void runMarkersAndDropKeptList() {
+        Object[] tmp = keptObjects;
+        keptObjects = new Object[cacheSize];
+        runAllMarkers();
+    }
+
     private synchronized void runAllMarkers() {
         MarkerReference currentMarker = getFirst();
         MarkerReference nextMarker;

src/main/java/org/truffleruby/options/Options.java

@@ -145,6 +145,7 @@ public class Options {
     public final boolean CEXTS_LOG_LOAD;
     public final boolean CEXTS_LOG_WARNINGS;
     public final String[] CEXTS_LIBRARY_REMAP;
+    public final int CEXTS_MARKING_CACHE;
     public final boolean LOG_DYNAMIC_CONSTANT_LOOKUP;
     public final boolean OPTIONS_LOG;
     public final boolean LOG_LOAD;
@@ -273,6 +274,7 @@ public class Options {
         CEXTS_LOG_LOAD = builder.getOrDefault(OptionsCatalog.CEXTS_LOG_LOAD);
         CEXTS_LOG_WARNINGS = builder.getOrDefault(OptionsCatalog.CEXTS_LOG_WARNINGS);
         CEXTS_LIBRARY_REMAP = builder.getOrDefault(OptionsCatalog.CEXTS_LIBRARY_REMAP);
+        CEXTS_MARKING_CACHE = builder.getOrDefault(OptionsCatalog.CEXTS_MARKING_CACHE);
         LOG_DYNAMIC_CONSTANT_LOOKUP = builder.getOrDefault(OptionsCatalog.LOG_DYNAMIC_CONSTANT_LOOKUP);
         OPTIONS_LOG = builder.getOrDefault(OptionsCatalog.OPTIONS_LOG);
         LOG_LOAD = builder.getOrDefault(OptionsCatalog.LOG_LOAD);
@@ -523,6 +525,8 @@ public Object fromDescription(OptionDescription<?> description) {
                 return CEXTS_LOG_WARNINGS;
             case "ruby.cexts.remap":
                 return CEXTS_LIBRARY_REMAP;
+            case "ruby.cexts.marking.cache":
+                return CEXTS_MARKING_CACHE;
             case "ruby.constant.dynamic_lookup.log":
                 return LOG_DYNAMIC_CONSTANT_LOOKUP;
             case "ruby.options.log":

src/shared/java/org/truffleruby/shared/options/OptionsCatalog.java

@@ -616,6 +616,11 @@ public class OptionsCatalog {
             "Remap the name of native libraries, written in the form libexample.so:/path/to/actual/libexample.so",
             null,
             new String[]{});
+    public static final IntegerOptionDescription CEXTS_MARKING_CACHE = new IntegerOptionDescription(
+            "ruby.cexts.marking.cache",
+            "Number of objects converted to native handles before the marker is run",
+            null,
+            100);
     public static final BooleanOptionDescription LOG_DYNAMIC_CONSTANT_LOOKUP = new BooleanOptionDescription(
             "ruby.constant.dynamic_lookup.log",
             "Log source code positions where dynamic constant lookup is performed",
@@ -889,6 +894,8 @@ public static OptionDescription<?> fromName(String name) {
                 return CEXTS_LOG_WARNINGS;
             case "ruby.cexts.remap":
                 return CEXTS_LIBRARY_REMAP;
+            case "ruby.cexts.marking.cache":
+                return CEXTS_MARKING_CACHE;
             case "ruby.constant.dynamic_lookup.log":
                 return LOG_DYNAMIC_CONSTANT_LOOKUP;
             case "ruby.options.log":
@@ -930,6 +937,7 @@ public static OptionDescription<?>[] allDescriptions() {
             CEXT_LOCK,
             CEXTS_LOG_LOAD,
             CEXTS_LOG_WARNINGS,
+            CEXTS_MARKING_CACHE,
             CEXTS_LIBRARY_REMAP,
             CLASS_CACHE,
             CLONE_DEFAULT,

tool/options.yml

@@ -136,6 +136,7 @@ CEXTS: [cexts, boolean, true, Enable use of C extensions]
 CEXTS_LOG_LOAD: [cexts.log.load, boolean, false, Log loading of cexts]
 CEXTS_LOG_WARNINGS: [cexts.log.warnings, boolean, false, Log cexts warnings]
 CEXTS_LIBRARY_REMAP: [cexts.remap, string-array, [], 'Remap the name of native libraries, written in the form libexample.so:/path/to/actual/libexample.so']
+CEXTS_MARKING_CACHE: [cexts.marking.cache, integer, 100, 'Number of objects converted to native handles before the marker is run']
 
 LOG_DYNAMIC_CONSTANT_LOOKUP: [constant.dynamic_lookup.log, boolean, false, Log source code positions where dynamic constant lookup is performed]