[GR-17457] Refactor nodes to get rid of CreateCast (part 2)

PullRequest: truffleruby/3882

Author: horakivo

spec/truffle/parsing/fixtures/and.yaml

@@ -4,7 +4,7 @@ focused_on_node: "org.truffleruby.language.control.AndNode"
 ruby: |
   1 and 2
 ast: |
-  AndNode
+  AndNodeGen
       attributes:
           flags = 1
       children:

spec/truffle/parsing/fixtures/block/argument_descriptors/with_optional_positional_parameters.yaml

@@ -45,73 +45,67 @@ ast: |
                               flags = 12
                           children:
                               body = [
-                                  IfElseNode
+                                  IfElseNodeGen
                                       attributes:
                                           flags = 0
                                       children:
                                           condition =
-                                              BooleanCastNodeGen
+                                              AndNodeGen
+                                                  attributes:
+                                                      flags = 0
                                                   children:
-                                                      valueNode_ =
-                                                          AndNode
+                                                      left =
+                                                          ShouldDestructureNode
+                                                              attributes:
+                                                                  flags = 0
+                                                                  keywordArguments = false
+                                                      right =
+                                                          SequenceNode
                                                               attributes:
                                                                   flags = 0
                                                               children:
-                                                                  left =
-                                                                      ShouldDestructureNode
-                                                                          attributes:
-                                                                              flags = 0
-                                                                              keywordArguments = false
-                                                                  right =
-                                                                      SequenceNode
+                                                                  body = [
+                                                                      WriteLocalVariableNode
                                                                           attributes:
                                                                               flags = 0
+                                                                              frameSlot = 4
                                                                           children:
-                                                                              body = [
-                                                                                  WriteLocalVariableNode
+                                                                              valueNode =
+                                                                                  SplatCastNodeGen
                                                                                       attributes:
+                                                                                          conversionMethod = :to_ary
+                                                                                          copy = false
                                                                                           flags = 0
-                                                                                          frameSlot = 4
+                                                                                          nilBehavior = NIL
                                                                                       children:
-                                                                                          valueNode =
-                                                                                              SplatCastNodeGen
+                                                                                          childNode_ =
+                                                                                              ProfileArgumentNodeGen
                                                                                                   attributes:
-                                                                                                      conversionMethod = :to_ary
-                                                                                                      copy = false
                                                                                                       flags = 0
-                                                                                                      nilBehavior = NIL
                                                                                                   children:
                                                                                                       childNode_ =
-                                                                                                          ProfileArgumentNodeGen
+                                                                                                          ReadPreArgumentNode
                                                                                                               attributes:
                                                                                                                   flags = 0
-                                                                                                              children:
-                                                                                                                  childNode_ =
-                                                                                                                      ReadPreArgumentNode
-                                                                                                                          attributes:
-                                                                                                                              flags = 0
-                                                                                                                              index = 0
-                                                                                                                              keywordArguments = false
-                                                                                                                              missingArgumentBehavior = RUNTIME_ERROR
-                                                                                  NotNode
+                                                                                                                  index = 0
+                                                                                                                  keywordArguments = false
+                                                                                                                  missingArgumentBehavior = RUNTIME_ERROR
+                                                                      NotNodeGen
+                                                                          attributes:
+                                                                              flags = 0
+                                                                          children:
+                                                                              child =
+                                                                                  IsNilNode
                                                                                       attributes:
                                                                                           flags = 0
                                                                                       children:
                                                                                           child =
-                                                                                              BooleanCastNodeGen
-                                                                                                  children:
-                                                                                                      valueNode_ =
-                                                                                                          IsNilNode
-                                                                                                              attributes:
-                                                                                                                  flags = 0
-                                                                                                              children:
-                                                                                                                  child =
-                                                                                                                      ReadLocalVariableNode
-                                                                                                                          attributes:
-                                                                                                                              flags = 0
-                                                                                                                              frameSlot = 4
-                                                                                                                              type = FRAME_LOCAL
-                                                                              ]
+                                                                                              ReadLocalVariableNode
+                                                                                                  attributes:
+                                                                                                      flags = 0
+                                                                                                      frameSlot = 4
+                                                                                                      type = FRAME_LOCAL
+                                                                  ]
                                           elseBody =
                                               SequenceNode
                                                   attributes: