Remove extra public methods on IO

* IO#read_bom_byte was never used.

Author: eregon

spec/tags/truffle/methods_tags.txt

@@ -25,20 +25,9 @@ fails:Public methods on IO should include pread
 fails:Public methods on IO should include pwrite
 fails:Public methods on IO should not include dup
 fails:Public methods on IO should not include encode_with
-fails:Public methods on IO should not include eof!
-fails:Public methods on IO should not include force_read_only
-fails:Public methods on IO should not include force_write_only
-fails:Public methods on IO should not include mode_read_only?
-fails:Public methods on IO should not include mode_write_only?
 fails:Public methods on IO should not include nonblock
 fails:Public methods on IO should not include nonblock=
 fails:Public methods on IO should not include nonblock?
-fails:Public methods on IO should not include pid=
-fails:Public methods on IO should not include pipe=
-fails:Public methods on IO should not include pipe?
-fails:Public methods on IO should not include read_bom_byte
-fails:Public methods on IO should not include reset_buffering
-fails:Public methods on IO should not include strip_bom
 fails:Public methods on Kernel should include then
 fails:Public methods on Numeric should include clone
 fails:Public methods on Numeric should include dup

src/main/ruby/truffleruby/core/io.rb

@@ -202,7 +202,7 @@ def fill_from(io, skip = nil)
 
         reset!
         if fill(io) == 0
-          io.eof!
+          io.instance_variable_set(:@eof, true)
           @eof = true
         end
 
@@ -348,20 +348,20 @@ def inspect # :nodoc:
     end
   end
 
-  def mode_read_only?
+  private def mode_read_only?
     @mode & ACCMODE == RDONLY
   end
 
-  def mode_write_only?
+  private def mode_write_only?
     @mode & ACCMODE == WRONLY
   end
 
-  def force_read_only
+  private def force_read_only
     @mode &= ~IO::ACCMODE
     @mode |= RDONLY
   end
 
-  def force_write_only
+  private def force_write_only
     @mode &= ~IO::ACCMODE
     @mode |= WRONLY
   end
@@ -439,7 +439,7 @@ def run
       end
 
       if @offset
-        if @from_io && !@from.pipe?
+        if @from_io && !@from.instance_variable_get(:@pipe)
           saved_pos = @from.pos
         else
           saved_pos = 0
@@ -903,7 +903,7 @@ def self.popen(*args)
       pid = Truffle::ProcessOperations.spawn(env || {}, *cmd, options)
     end
 
-    pipe.pid = pid
+    pipe.instance_variable_set :@pid, pid
 
     ch_write.close if readable
     ch_read.close  if writable
@@ -1594,13 +1594,6 @@ def each_codepoint
   end
   alias_method :codepoints, :each_codepoint
 
-
-  ##
-  # Set the pipe so it is at the end of the file
-  def eof!
-    @eof = true
-  end
-
   ##
   # Returns true if ios is at end of file that means
   # there are no more data to read. The stream must be
@@ -1869,16 +1862,6 @@ def pid
     @pid
   end
 
-  attr_writer :pid
-
-  def pipe=(v)
-    @pipe = !!v
-  end
-
-  def pipe?
-    @pipe
-  end
-
   def pos
     flush
     reset_buffering
@@ -2201,7 +2184,7 @@ def reopen(other, mode=undefined)
           io.ensure_open
         end
 
-        io.reset_buffering
+        io.__send__(:reset_buffering)
 
         Truffle::IOOperations.dup2_with_cloexec(io.fileno, @descriptor)
 
@@ -2250,7 +2233,7 @@ def reopen(other, mode=undefined)
   ##
   # Internal method used to reset the state of the buffer, including the
   # physical position in the stream.
-  def reset_buffering
+  private def reset_buffering
     @ibuffer.unseek! self
   end
 
@@ -2355,12 +2338,7 @@ def set_encoding(external, internal=nil, options=undefined)
     self
   end
 
-  def read_bom_byte
-    read_ios, _, _ = IO.select [self], nil, nil, 0.1
-    getbyte if read_ios
-  end
-
-  def strip_bom
+  private def strip_bom
     mode = Truffle::POSIX.truffleposix_fstat_mode(@descriptor)
     return unless Truffle::StatOperations.file?(mode)
 

src/main/ruby/truffleruby/core/truffle/io_operations.rb

@@ -101,7 +101,7 @@ def self.dup2_with_cloexec(old_fd, new_fd)
     def self.pipe_end_setup(io)
       io.close_on_exec = true
       io.sync = true
-      io.pipe = true
+      io.instance_variable_set :@pipe, true
       io
     end