[GR-19220] Option to add chaos to data representations to stress specialization code paths (#2368)

PullRequest: truffleruby/2799

Author: eregon

spec/truffle/array/append_spec.rb

@@ -23,102 +23,104 @@ def storage(ary)
     storage(ary).should == "empty"
   end
 
-  it "supports transitions from null storage" do
-    ary = [] << 1
-    ary.should == [1]
-    storage(ary).should == "int[]"
-
-    ary = [] << @long
-    ary.should == [@long]
-    storage(ary).should == "long[]"
-
-    ary = [] << 1.33
-    ary.should == [1.33]
-    storage(ary).should == "double[]"
-
-    o = Object.new
-    ary = [] << o
-    ary.should == [o]
-    storage(ary).should == "Object[]"
-  end
+  guard -> { !Truffle::Boot.get_option('chaos-data') } do
+    it "supports transitions from null storage" do
+      ary = [] << 1
+      ary.should == [1]
+      storage(ary).should == "int[]"
 
-  it "supports adding the same type" do
-    ary = [1] << 2
-    ary.should == [1, 2]
-    storage(ary).should == "int[]"
+      ary = [] << @long
+      ary.should == [@long]
+      storage(ary).should == "long[]"
 
-    ary = [@long] << @long+1
-    ary.should == [@long, @long+1]
-    storage(ary).should == "long[]"
+      ary = [] << 1.33
+      ary.should == [1.33]
+      storage(ary).should == "double[]"
 
-    ary = [3.14] << 3.15
-    ary.should == [3.14, 3.15]
-    storage(ary).should == "double[]"
+      o = Object.new
+      ary = [] << o
+      ary.should == [o]
+      storage(ary).should == "Object[]"
+    end
 
-    a, b = Object.new, Object.new
-    ary = [a] << b
-    ary.should == [a, b]
-    storage(ary).should == "Object[]"
-  end
+    it "supports adding the same type" do
+      ary = [1] << 2
+      ary.should == [1, 2]
+      storage(ary).should == "int[]"
 
-  it "supports long[] << int" do
-    long_ary = [@long, @long+1, @long+2]
-    storage(long_ary).should == "long[]"
+      ary = [@long] << @long+1
+      ary.should == [@long, @long+1]
+      storage(ary).should == "long[]"
 
-    long_ary << 1
-    long_ary.should == [@long, @long+1, @long+2, 1]
-    storage(long_ary).should == "long[]"
-  end
+      ary = [3.14] << 3.15
+      ary.should == [3.14, 3.15]
+      storage(ary).should == "double[]"
 
-  it "supports int[] << long and goes to long[]" do
-    # Make sure long[] is chosen even if there was a int[] << Object before
-    2.times do |i|
-      setup = (i == 0)
+      a, b = Object.new, Object.new
+      ary = [a] << b
+      ary.should == [a, b]
+      storage(ary).should == "Object[]"
+    end
 
-      ary = [0, 1, 2]
-      storage(ary).should == "int[]"
+    it "supports long[] << int" do
+      long_ary = [@long, @long+1, @long+2]
+      storage(long_ary).should == "long[]"
 
-      obj = (i == 0) ? Object.new : @long
-      ary << obj
-      ary.should == [0, 1, 2, obj]
-      storage(ary).should == (setup ? "Object[]" : "long[]")
+      long_ary << 1
+      long_ary.should == [@long, @long+1, @long+2, 1]
+      storage(long_ary).should == "long[]"
     end
-  end
 
-  it "supports int[] << double" do
-    ary = [0, 1, 2]
-    storage(ary).should == "int[]"
+    it "supports int[] << long and goes to long[]" do
+      # Make sure long[] is chosen even if there was a int[] << Object before
+      2.times do |i|
+        setup = (i == 0)
 
-    ary << 1.34
-    ary.should == [0, 1, 2, 1.34]
-    storage(ary).should == "Object[]"
-  end
+        ary = [0, 1, 2]
+        storage(ary).should == "int[]"
 
-  it "supports long[] << double" do
-    long_ary = [@long, @long+1, @long+2]
-    storage(long_ary).should == "long[]"
+        obj = (i == 0) ? Object.new : @long
+        ary << obj
+        ary.should == [0, 1, 2, obj]
+        storage(ary).should == (setup ? "Object[]" : "long[]")
+      end
+    end
 
-    long_ary << 1.34
-    long_ary.should == [@long, @long+1, @long+2, 1.34]
-    storage(long_ary).should == "Object[]"
-  end
+    it "supports int[] << double" do
+      ary = [0, 1, 2]
+      storage(ary).should == "int[]"
 
-  it "supports double[] << int" do
-    ary = [3.14, 3.15]
-    storage(ary).should == "double[]"
+      ary << 1.34
+      ary.should == [0, 1, 2, 1.34]
+      storage(ary).should == "Object[]"
+    end
 
-    ary << 4
-    ary.should == [3.14, 3.15, 4]
-    storage(ary).should == "Object[]"
-  end
+    it "supports long[] << double" do
+      long_ary = [@long, @long+1, @long+2]
+      storage(long_ary).should == "long[]"
 
-  it "supports Object[] << int" do
-    o = Object.new
-    ary = [o]
-    storage(ary).should == "Object[]"
+      long_ary << 1.34
+      long_ary.should == [@long, @long+1, @long+2, 1.34]
+      storage(long_ary).should == "Object[]"
+    end
 
-    ary << 4
-    ary.should == [o, 4]
-    storage(ary).should == "Object[]"
+    it "supports double[] << int" do
+      ary = [3.14, 3.15]
+      storage(ary).should == "double[]"
+
+      ary << 4
+      ary.should == [3.14, 3.15, 4]
+      storage(ary).should == "Object[]"
+    end
+
+    it "supports Object[] << int" do
+      o = Object.new
+      ary = [o]
+      storage(ary).should == "Object[]"
+
+      ary << 4
+      ary.should == [o, 4]
+      storage(ary).should == "Object[]"
+    end
   end
 end

spec/truffle/array/element_set_spec.rb

@@ -17,80 +17,82 @@ def storage(ary)
     @long = 1 << 52
   end
 
-  it "migrates to the most specific storage if initially empty" do
-    ary = []
-    ary[0] = Object.new
-    storage(ary).should == "Object[]"
-
-    ary = []
-    ary[0] = 3.14
-    storage(ary).should == "double[]"
-
-    ary = []
-    ary[0] = @long
-    storage(ary).should == "long[]"
-
-    ary = []
-    ary[0] = 1
-    storage(ary).should == "int[]"
-  end
-
-  it "keeps the same storage if compatible and in bounds" do
-    ary = [Object.new, Object.new]
-    ary[1] = Object.new
-    storage(ary).should == "Object[]"
-
-    ary = [3.11, 3.12]
-    ary[1] = 3.14
-    storage(ary).should == "double[]"
-
-    ary = [@long-2, @long-1]
-    ary[1] = @long
-    storage(ary).should == "long[]"
-
-    ary = [@long-2, @long-1]
-    ary[1] = 3
-    storage(ary).should == "long[]"
-
-    ary = [0, 1]
-    ary[1] = 2
-    storage(ary).should == "int[]"
-  end
-
-  it "generalizes if not compatible and in bounds" do
-    ary = [3.11, 3.12]
-    ary[1] = Object.new
-    storage(ary).should == "Object[]"
-
-    ary = [@long-2, @long-1]
-    ary[1] = 3.14
-    storage(ary).should == "Object[]"
-
-    ary = [0, 1]
-    ary[1] = @long
-    storage(ary).should == "long[]"
-
-    ary = [0, 1]
-    ary[1] = Object.new
-    storage(ary).should == "Object[]"
-  end
-
-  it "keeps the same storage if compatible and appending" do
-    ary = [Object.new, Object.new]
-    ary[2] = Object.new
-    storage(ary).should == "Object[]"
-
-    ary = [3.11, 3.12]
-    ary[2] = 3.14
-    storage(ary).should == "double[]"
-
-    ary = [@long-2, @long-1]
-    ary[2] = @long
-    storage(ary).should == "long[]"
-
-    ary = [0, 1]
-    ary[2] = 2
-    storage(ary).should == "int[]"
+  guard -> { !Truffle::Boot.get_option('chaos-data') } do
+    it "migrates to the most specific storage if initially empty" do
+      ary = []
+      ary[0] = Object.new
+      storage(ary).should == "Object[]"
+
+      ary = []
+      ary[0] = 3.14
+      storage(ary).should == "double[]"
+
+      ary = []
+      ary[0] = @long
+      storage(ary).should == "long[]"
+
+      ary = []
+      ary[0] = 1
+      storage(ary).should == "int[]"
+    end
+
+    it "keeps the same storage if compatible and in bounds" do
+      ary = [Object.new, Object.new]
+      ary[1] = Object.new
+      storage(ary).should == "Object[]"
+
+      ary = [3.11, 3.12]
+      ary[1] = 3.14
+      storage(ary).should == "double[]"
+
+      ary = [@long-2, @long-1]
+      ary[1] = @long
+      storage(ary).should == "long[]"
+
+      ary = [@long-2, @long-1]
+      ary[1] = 3
+      storage(ary).should == "long[]"
+
+      ary = [0, 1]
+      ary[1] = 2
+      storage(ary).should == "int[]"
+    end
+
+    it "generalizes if not compatible and in bounds" do
+      ary = [3.11, 3.12]
+      ary[1] = Object.new
+      storage(ary).should == "Object[]"
+
+      ary = [@long-2, @long-1]
+      ary[1] = 3.14
+      storage(ary).should == "Object[]"
+
+      ary = [0, 1]
+      ary[1] = @long
+      storage(ary).should == "long[]"
+
+      ary = [0, 1]
+      ary[1] = Object.new
+      storage(ary).should == "Object[]"
+    end
+
+    it "keeps the same storage if compatible and appending" do
+      ary = [Object.new, Object.new]
+      ary[2] = Object.new
+      storage(ary).should == "Object[]"
+
+      ary = [3.11, 3.12]
+      ary[2] = 3.14
+      storage(ary).should == "double[]"
+
+      ary = [@long-2, @long-1]
+      ary[2] = @long
+      storage(ary).should == "long[]"
+
+      ary = [0, 1]
+      ary[2] = 2
+      storage(ary).should == "int[]"
+    end
   end
 
   it "migrates to Object[] if writing out of bounds" do

spec/truffle/array/steal_array_storage.rb

@@ -20,25 +20,27 @@ def storage(ary)
     @array = %i[first second third]
   end
 
-  it "should no-op when called on itself" do
-    copy = @array.dup
+  guard -> { !Truffle::Boot.get_option('chaos-data') } do
+    it "should no-op when called on itself" do
+      copy = @array.dup
 
-    Primitive.steal_array_storage(@array, @array)
+      Primitive.steal_array_storage(@array, @array)
 
-    storage(@array).should == "Object[]"
-    @array.should == copy
-  end
+      storage(@array).should == "Object[]"
+      @array.should == copy
+    end
 
-  it "should take ownership of the store" do
-    other = [1, 2, 3, 4, 5]
-    other_copy = other.dup
+    it "should take ownership of the store" do
+      other = [1, 2, 3, 4, 5]
+      other_copy = other.dup
 
-    Primitive.steal_array_storage(@array, other)
+      Primitive.steal_array_storage(@array, other)
 
-    storage(@array).should == "int[]"
-    @array.should == other_copy
+      storage(@array).should == "int[]"
+      @array.should == other_copy
 
-    storage(other).should == "null"
-    other.empty?.should == true
+      storage(other).should == "null"
+      other.empty?.should == true
+    end
   end
 end