[GR-19220] Add Truffle::Ropes.convert_to_native (#2345)

PullRequest: truffleruby/2643

Author: eregon

src/main/java/org/truffleruby/core/rope/RopeNodes.java

@@ -35,7 +35,6 @@
 import org.truffleruby.core.rope.RopeNodesFactory.SetByteNodeGen;
 import org.truffleruby.core.string.StringAttributes;
 import org.truffleruby.core.string.StringSupport;
-import org.truffleruby.core.string.StringUtils;
 import org.truffleruby.language.NotProvided;
 import org.truffleruby.language.RubyBaseNode;
 import org.truffleruby.language.RubyContextNode;
@@ -745,7 +744,7 @@ protected Object debugPrintLeafRope(LeafRope rope, int currentLevel, boolean pri
             // Converting a rope to a java.lang.String may populate the byte[], so we need to query for the array status beforehand.
             final boolean bytesAreNull = rope.getRawBytes() == null;
 
-            System.err.println(StringUtils.format(
+            System.err.println(String.format(
                     "%s (%s; BN: %b; BL: %d; CL: %d; CR: %s; E: %s)",
                     printString ? RopeOperations.escape(rope) : "<skipped>",
                     rope.getClass().getSimpleName(),
@@ -766,7 +765,7 @@ protected Object debugPrintSubstringRope(SubstringRope rope, int currentLevel, b
             // Converting a rope to a java.lang.String may populate the byte[], so we need to query for the array status beforehand.
             final boolean bytesAreNull = rope.getRawBytes() == null;
 
-            System.err.println(StringUtils.format(
+            System.err.println(String.format(
                     "%s (%s; BN: %b; BL: %d; CL: %d; CR: %s; O: %d; E: %s)",
                     printString ? RopeOperations.escape(rope) : "<skipped>",
                     rope.getClass().getSimpleName(),
@@ -793,7 +792,7 @@ protected Object debugPrintConcatRopeBytes(ConcatRope rope, int currentLevel, bo
             final boolean bytesAreNull = rope.getRawBytes() == null;
 
             if (state.isFlattened()) {
-                System.err.println(StringUtils.format(
+                System.err.println(String.format(
                         "%s (%s; BN: %b; BL: %d; CL: %d; CR: %s; E: %s)",
                         printString ? RopeOperations.escape(rope) : "<skipped>",
                         rope.getClass().getSimpleName(),
@@ -803,7 +802,7 @@ protected Object debugPrintConcatRopeBytes(ConcatRope rope, int currentLevel, bo
                         rope.getCodeRange(),
                         rope.getEncoding()));
             } else {
-                System.err.println(StringUtils.format(
+                System.err.println(String.format(
                         "%s (%s; BN: %b; BL: %d; CL: %d; CR: %s; E: %s)",
                         printString ? RopeOperations.escape(rope) : "<skipped>",
                         rope.getClass().getSimpleName(),
@@ -828,7 +827,7 @@ protected Object debugPrintRepeatingRope(RepeatingRope rope, int currentLevel, b
             // Converting a rope to a java.lang.String may populate the byte[], so we need to query for the array status beforehand.
             final boolean bytesAreNull = rope.getRawBytes() == null;
 
-            System.err.println(StringUtils.format(
+            System.err.println(String.format(
                     "%s (%s; BN: %b; BL: %d; CL: %d; CR: %s; T: %d; D: %d; E: %s)",
                     printString ? RopeOperations.escape(rope) : "<skipped>",
                     rope.getClass().getSimpleName(),
@@ -852,7 +851,7 @@ protected Object debugPrintLazyInt(LazyIntRope rope, int currentLevel, boolean p
             // Converting a rope to a java.lang.String may populate the byte[], so we need to query for the array status beforehand.
             final boolean bytesAreNull = rope.getRawBytes() == null;
 
-            System.err.println(StringUtils.format(
+            System.err.println(String.format(
                     "%s (%s; BN: %b; BL: %d; CL: %d; CR: %s; V: %d, D: %d; E: %s)",
                     printString ? RopeOperations.escape(rope) : "<skipped>",
                     rope.getClass().getSimpleName(),
@@ -866,6 +865,25 @@ protected Object debugPrintLazyInt(LazyIntRope rope, int currentLevel, boolean p
             return nil;
         }
 
+        @TruffleBoundary
+        @Specialization
+        protected Object debugPrintNative(NativeRope rope, int currentLevel, boolean printString) {
+            printPreamble(currentLevel);
+
+            System.err.println(String.format(
+                    "%s (%s; BL: %d; CL: %d; CR: %s; P: 0x%x, S: %d; E: %s)",
+                    printString ? RopeOperations.escape(rope) : "<skipped>",
+                    rope.getClass().getSimpleName(),
+                    rope.byteLength(),
+                    rope.characterLength(),
+                    rope.getCodeRange(),
+                    rope.getNativePointer().getAddress(),
+                    rope.getNativePointer().getSize(),
+                    rope.getEncoding()));
+
+            return nil;
+        }
+
         private void printPreamble(int level) {
             if (level > 0) {
                 for (int i = 0; i < level; i++) {

src/main/java/org/truffleruby/core/rope/TruffleRopesNodes.java

@@ -14,6 +14,7 @@
 import org.truffleruby.builtins.CoreMethod;
 import org.truffleruby.builtins.CoreMethodArrayArgumentsNode;
 import org.truffleruby.builtins.CoreModule;
+import org.truffleruby.cext.CExtNodes;
 import org.truffleruby.core.rope.ConcatRope.ConcatState;
 import org.truffleruby.core.string.RubyString;
 import org.truffleruby.core.string.StringNodes;
@@ -79,6 +80,8 @@ protected Object debugPrint(Object string, boolean printString,
             System.err.println("LD = Left Depth (ConcatRope only)");
             System.err.println("RD = Right Depth (ConcatRope only)");
             System.err.println("E = Encoding");
+            System.err.println("P = Native Pointer (NativeRope only)");
+            System.err.println("S = Native Size (NativeRope only)");
 
             return debugPrintRopeNode.executeDebugPrint(strings.getRope(string), 0, printString);
         }
@@ -164,6 +167,19 @@ protected RubyString flattenRope(Object string,
 
     }
 
+    @CoreMethod(names = "convert_to_native", onSingleton = true, required = 1)
+    public abstract static class NativeRopeNode extends CoreMethodArrayArgumentsNode {
+
+        @Specialization(guards = "strings.isRubyString(string)")
+        protected Object nativeRope(Object string,
+                @Cached CExtNodes.StringToNativeNode toNativeNode,
+                @CachedLibrary(limit = "2") RubyStringLibrary strings) {
+            toNativeNode.executeToNative(string);
+            return string;
+        }
+
+    }
+
     /* Truffle.create_simple_string creates a string 'test' without any part of the string escaping. Useful for testing
      * compilation of String because most other ways to construct a string can currently escape. */
 

src/main/java/org/truffleruby/core/string/StringNodes.java

@@ -4936,7 +4936,6 @@ protected Object splicePrepend(
                 @Cached RopeNodes.SubstringNode prependSubstringNode,
                 @Cached RopeNodes.ConcatNode prependConcatNode,
                 @CachedLibrary(limit = "2") RubyStringLibrary libOther) {
-
             final Encoding encoding = rubyEncoding.encoding;
             final Rope original = string.rope;
             final Rope left = libOther.getRope(other);
@@ -4972,7 +4971,6 @@ protected RubyString splice(
                 @Cached RopeNodes.ConcatNode leftConcatNode,
                 @Cached RopeNodes.ConcatNode rightConcatNode,
                 @CachedLibrary(limit = "2") RubyStringLibrary libOther) {
-
             final Encoding encoding = rubyEncoding.encoding;
             final Rope source = string.rope;
             final Rope insert = libOther.getRope(other);