Directly return a native pointer for RSTRING_PTR() if the String is already native

eregon · eregon · commit 26cc873bf941 · 2020-01-29T19:34:08.000+01:00
* 110s => 64s for a small `bundle install`. (cherry picked from commit 190cf34)
diff --git a/src/main/c/cext/ruby.c b/src/main/c/cext/ruby.c
@@ -812,7 +812,11 @@ char *rb_string_value_cstr(VALUE *value_pointer) {
 }
 
 char *RSTRING_PTR_IMPL(VALUE string) {
-  return (char *)polyglot_as_i8_array(RUBY_CEXT_INVOKE_NO_WRAP("RSTRING_PTR", string));
+  if (polyglot_as_boolean(RUBY_CEXT_INVOKE_NO_WRAP("native_string?", string))) {
+    return NATIVE_RSTRING_PTR(string);
+  } else {
+    return (char *)polyglot_as_i8_array(RUBY_CEXT_INVOKE_NO_WRAP("RSTRING_PTR", string));
+  }
 }
 
 char *RSTRING_END(VALUE string) {

Original file line number	Diff line number	Diff line change
`@@ -812,7 +812,11 @@ char rb_string_value_cstr(VALUE value_pointer) {`
`812`	`812`	`}`
`813`	`813`
`814`	`814`	`char *RSTRING_PTR_IMPL(VALUE string) {`
`815`		`- return (char *)polyglot_as_i8_array(RUBY_CEXT_INVOKE_NO_WRAP("RSTRING_PTR", string));`
	`815`	`+ if (polyglot_as_boolean(RUBY_CEXT_INVOKE_NO_WRAP("native_string?", string))) {`
	`816`	`+ return NATIVE_RSTRING_PTR(string);`
	`817`	`+ } else {`
	`818`	`+ return (char *)polyglot_as_i8_array(RUBY_CEXT_INVOKE_NO_WRAP("RSTRING_PTR", string));`
	`819`	`+ }`
`816`	`820`	`}`
`817`	`821`
`818`	`822`	`char *RSTRING_END(VALUE string) {`