[GR-17818] Make Array#swap private so it does not leak into keys.

PullRequest: truffleruby/1169

Author: pitr-ch

CHANGELOG.md

@@ -32,6 +32,7 @@ Bug fixes:
 * Fixed `Module#to_s` and `Module#inspect` to not return an extra `#<Class:` for singleton classes.
 * Arrays backed by native storage now allocate the correct amount of memory (#1828).
 * Fixed issue in `ConditionVariable#wait` that could lose a `ConditionVariable#signal`.
+* Do not leak TruffleRuby specific method Array#swap (#1816)
 
 Compatibility:
 

src/main/ruby/truffleruby/core/array.rb

@@ -1105,7 +1105,7 @@ def sample_many(count, rng)
     result = Array.new(self)
 
     count.times do |c|
-      result.swap c, rng.rand(size)
+      Truffle.privately { result.swap c, rng.rand(size) }
     end
 
     count == size ? result : result[0, count]
@@ -1670,10 +1670,11 @@ def sort!(&block)
     TrufflePrimitive.steal_array_storage(self, sort(&block))
   end
 
+  private
+
   def swap(a, b)
     temp = at(a)
     self[a] = at(b)
     self[b] = temp
   end
-  protected :swap
 end

src/main/ruby/truffleruby/core/truffle/interop.rb

@@ -48,6 +48,7 @@ def self.object_keys(object, internal)
         # FIXME (pitr-ch 11-May-2019): remove the branch
         keys = []
       else
+        # TODO (pitr-ch 28-Nov-2019): make sure protected methods are not listed unless internal
         keys = []
         object.methods.each do |method|
           keys << method.to_s if Truffle::Type.object_respond_to? object, method, true