[GR-20165] Fix Kernel#clone for special values.

PullRequest: truffleruby/1199

Author: eregon

CHANGELOG.md

@@ -50,6 +50,7 @@ Bug fixes:
 * Implement Numeric#clone method to return self.
 * Fixed `Symbol#to_proc` to create proc with nil `source_location` (#1663).
 * Make `GC.start` work with keyword arguments.
+* Fixed `Kernel#clone` for `nil`, `true`, `false`, `Integer`, and `Symbol`.
 
 Compatibility:
 

spec/tags/core/kernel/clone_tags.txt

@@ -225,6 +225,11 @@ public DynamicObject argumentErrorInvalidBigDecimal(String string, Node currentN
         return argumentError(StringUtils.format("invalid value for BigDecimal(): \"%s\"", string), currentNode);
     }
 
+    public DynamicObject argumentErrorCantUnfreeze(Object self, Node currentNode) {
+        String className = Layouts.MODULE.getFields(context.getCoreLibrary().getLogicalClass(self)).getName();
+        return argumentError(StringUtils.format("can't unfreeze %s", className), currentNode);
+    }
+
     // FrozenError
 
     @TruffleBoundary

src/main/java/org/truffleruby/core/exception/CoreExceptions.java

@@ -459,7 +459,7 @@ protected RubyNode coerceToBoolean(RubyNode freeze) {
             return BooleanCastWithDefaultNodeGen.create(true, freeze);
         }
 
-        @Specialization
+        @Specialization(guards = { "!isNil(self)", "!isRubyBignum(self)", "!isRubySymbol(self)" })
         protected DynamicObject clone(VirtualFrame frame, DynamicObject self, boolean freeze,
                 @Cached("createBinaryProfile()") ConditionProfile isSingletonProfile,
                 @Cached("createBinaryProfile()") ConditionProfile freezeProfile,
@@ -494,6 +494,73 @@ protected DynamicObject clone(VirtualFrame frame, DynamicObject self, boolean fr
             return newObject;
         }
 
+        @Specialization
+        protected Object cloneBoolean(boolean self, boolean freeze,
+                @Cached("createBinaryProfile()") ConditionProfile freezeProfile) {
+            if (freezeProfile.profile(!freeze)) {
+                raiseCantUnfreezeError(self);
+            }
+            return self;
+        }
+
+        @Specialization
+        protected Object cloneInteger(int self, boolean freeze,
+                @Cached("createBinaryProfile()") ConditionProfile freezeProfile) {
+            if (freezeProfile.profile(!freeze)) {
+                raiseCantUnfreezeError(self);
+            }
+            return self;
+        }
+
+        @Specialization
+        protected Object cloneLong(long self, boolean freeze,
+                @Cached("createBinaryProfile()") ConditionProfile freezeProfile) {
+            if (freezeProfile.profile(!freeze)) {
+                raiseCantUnfreezeError(self);
+            }
+            return self;
+        }
+
+        @Specialization
+        protected Object cloneFloat(double self, boolean freeze,
+                @Cached("createBinaryProfile()") ConditionProfile freezeProfile) {
+            if (freezeProfile.profile(!freeze)) {
+                raiseCantUnfreezeError(self);
+            }
+            return self;
+        }
+
+        @Specialization(guards = "isNil(nil)")
+        protected Object cloneNil(Object nil, boolean freeze,
+                @Cached("createBinaryProfile()") ConditionProfile freezeProfile) {
+            if (freezeProfile.profile(!freeze)) {
+                raiseCantUnfreezeError(nil);
+            }
+            return nil;
+        }
+
+        @Specialization(guards = "isRubyBignum(object)")
+        protected Object cloneBignum(DynamicObject object, boolean freeze,
+                @Cached("createBinaryProfile()") ConditionProfile freezeProfile) {
+            if (freezeProfile.profile(!freeze)) {
+                raiseCantUnfreezeError(object);
+            }
+            return object;
+        }
+
+        @Specialization(guards = "isRubySymbol(symbol)")
+        protected Object cloneSymbol(DynamicObject symbol, boolean freeze,
+                @Cached("createBinaryProfile()") ConditionProfile freezeProfile) {
+            if (freezeProfile.profile(!freeze)) {
+                raiseCantUnfreezeError(symbol);
+            }
+            return symbol;
+        }
+
+        private void raiseCantUnfreezeError(Object self) {
+            throw new RaiseException(getContext(), coreExceptions().argumentErrorCantUnfreeze(self, this));
+        }
+
         private DynamicObject executeSingletonClass(DynamicObject newObject) {
             if (singletonClassNode == null) {
                 CompilerDirectives.transferToInterpreterAndInvalidate();

src/main/java/org/truffleruby/core/kernel/KernelNodes.java

@@ -51,10 +51,6 @@ def protected_singleton_methods
     []
   end
   private :protected_singleton_methods
-
-  def clone
-    raise TypeError, "can't clone #{self.class.name}"
-  end
 end
 
 class NilClass