Remove Hash#_get_or_undefined

Author: bjfish

lib/truffle/truffle/cext.rb

@@ -903,6 +903,10 @@ def rb_ident_hash_new
     {}.compare_by_identity
   end
 
+  def rb_hash_get_or_undefined(hash, key)
+    Primitive.hash_get_or_undefined(hash, key)
+  end
+
   def rb_hash_set_ifnone(hash, value)
     hash.default = value
   end

spec/tags/truffle/methods_tags.txt

@@ -14,7 +14,6 @@ fails:Public methods on Float should include positive?
 fails:Public methods on Float should include zero?
 fails:Public methods on Hash should include any?
 fails:Public methods on Hash should not include __store__
-fails:Public methods on Hash should not include _get_or_undefined
 fails:Public methods on Hash should not include collect
 fails:Public methods on Hash should not include map
 fails:Public methods on Hash should not include sort

src/main/c/cext/hash.c

@@ -48,7 +48,7 @@ VALUE rb_hash_lookup(VALUE hash, VALUE key) {
 }
 
 VALUE rb_hash_lookup2(VALUE hash, VALUE key, VALUE default_value) {
-  VALUE result = RUBY_INVOKE(hash, "_get_or_undefined", key);
+  VALUE result = RUBY_CEXT_INVOKE("rb_hash_get_or_undefined", hash, key);
   if (result == Qundef) {
     result = default_value;
   }

src/main/java/org/truffleruby/core/hash/HashNodes.java

@@ -231,8 +231,8 @@ public Object accept(VirtualFrame frame, Object hash, Object key) {
 
     }
 
-    @CoreMethod(names = "_get_or_undefined", required = 1)
-    public abstract static class GetOrUndefinedNode extends CoreMethodArrayArgumentsNode implements BiFunctionNode {
+    @Primitive(name = "hash_get_or_undefined")
+    public abstract static class GetOrUndefinedNode extends PrimitiveArrayArgumentsNode implements BiFunctionNode {
 
         @Child private HashLookupOrExecuteDefaultNode lookupNode = HashLookupOrExecuteDefaultNode.create();
 

src/main/ruby/truffleruby/core/hash.rb

@@ -143,7 +143,7 @@ def eql_op(op, other)
 
     Truffle::ThreadOperations.detect_pair_recursion self, other do
       each_pair do |key, value|
-        other_value = other._get_or_undefined(key)
+        other_value = Primitive.hash_get_or_undefined(other, key)
 
         # Other doesn't even have this key
         return false if Primitive.undefined?(other_value)
@@ -220,7 +220,7 @@ def deconstruct_keys(keys)
   end
 
   def fetch(key, default=undefined)
-    value = _get_or_undefined(key)
+    value = Primitive.hash_get_or_undefined(self, key)
     unless Primitive.undefined?(value)
       return value
     end
@@ -342,7 +342,7 @@ def select!
   def slice(*keys)
     res = {}
     keys.each do |k|
-      v = _get_or_undefined(k)
+      v = Primitive.hash_get_or_undefined(self, k)
       res[k] = v unless Primitive.undefined?(v)
     end
     res
@@ -428,7 +428,7 @@ def inspect
   alias_method :to_s, :inspect
 
   def key?(key)
-    !Primitive.undefined?(_get_or_undefined(key))
+    !Primitive.undefined?(Primitive.hash_get_or_undefined(self, key))
   end
   alias_method :has_key?, :key?
   alias_method :include?, :key?