Skip to content

Commit 1d89a7e

Browse files
committed
[GR-17457] Fix getting the JVMCI version for JDK latest in jt
PullRequest: truffleruby/4180
2 parents c770b10 + 5f37610 commit 1d89a7e

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

tool/jt.rb

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,12 @@ def jvmci_version
193193
sforceimports unless File.directory?(GRAAL_DIR)
194194
common_json = File.read(graal_common_json)
195195
edition = ee_jdk? ? 'ee' : 'ce'
196-
regex = /"labsjdk-#{edition}-#{@jdk_version}":\s*\{\s*"name":\s*"labsjdk"\s*,\s*"version":\s*"[^"]+-(jvmci-[^"]+)"\s*,/
196+
if @jdk_version == 'latest'
197+
# The version after "-jvmci-" is not enough for latest, we also need the JDK version
198+
regex = /"labsjdk-#{edition}-#{@jdk_version}":\s*\{\s*"name":\s*"labsjdk"\s*,\s*"version":\s*"(?:ce|ee)-([^"]+-jvmci-[^"]+)"\s*,/
199+
else
200+
regex = /"labsjdk-#{edition}-#{@jdk_version}":\s*\{\s*"name":\s*"labsjdk"\s*,\s*"version":\s*"[^"]+-(jvmci-[^"]+)"\s*,/
201+
end
197202
raise "JVMCI version not found for labsjdk-#{edition}-#{@jdk_version} in #{graal_common_json}" unless regex =~ common_json
198203
$1
199204
end
@@ -2355,7 +2360,7 @@ def install(name, *options)
23552360

23562361
ee = ee_jdk?
23572362
jdk_name = ee ? "labsjdk-ee-#{jdk_version}" : "labsjdk-ce-#{jdk_version}"
2358-
2363+
# We try to match the default directory name that mx fetch-jdk uses here to avoid extra symlinks
23592364
java_home = "#{JDKS_CACHE_DIR}/#{jdk_name}-#{jvmci_version}"
23602365
unless File.directory?(java_home)
23612366
STDERR.puts "#{download_message} (#{jdk_name})"

0 commit comments

Comments
 (0)