Add specs for StringIO#{each,each_line} when passed separator and limit parameters

Author: andrykonchin

spec/ruby/library/stringio/each_line_spec.rb

@@ -21,3 +21,7 @@
 describe "StringIO#each_line when passed limit" do
   it_behaves_like :stringio_each_limit, :each_line
 end
+
+describe "StringIO#each when passed separator and limit" do
+  it_behaves_like :stringio_each_separator_and_limit, :each_line
+end

spec/ruby/library/stringio/each_spec.rb

@@ -25,3 +25,7 @@
 describe "StringIO#each when passed limit" do
   it_behaves_like :stringio_each_limit, :each
 end
+
+describe "StringIO#each when passed separator and limit" do
+  it_behaves_like :stringio_each_separator_and_limit, :each
+end

spec/ruby/library/stringio/shared/each.rb

@@ -150,3 +150,60 @@
     seen.should == ["a b ", "c d ", "e\n", "1 2 ", "3 4 ", "5"]
   end
 end
+
+describe :stringio_each_separator_and_limit, shared: true do
+  before :each do
+    @io = StringIO.new("this>is>an>example")
+  end
+
+  it "returns the data read until the limit is consumed or the separator is met" do
+    @io.send(@method, '>', 8) { |s| break s }.should == "this>"
+    @io.send(@method, '>', 2) { |s| break s }.should == "is"
+    @io.send(@method, '>', 10) { |s| break s }.should == ">"
+    @io.send(@method, '>', 6) { |s| break s }.should == "an>"
+    @io.send(@method, '>', 5) { |s| break s }.should == "examp"
+  end
+
+  it "truncates the multi-character separator at the end to meet the limit" do
+    @io.send(@method, "is>an", 7) { |s| break s }.should == "this>is"
+  end
+
+  it "does not change $_" do
+    $_ = "test"
+    @io.send(@method, '>', 8) { |s| s }
+    $_.should == "test"
+  end
+
+  it "updates self's lineno by one" do
+    @io.send(@method, '>', 3) { |s| break s }
+    @io.lineno.should eql(1)
+
+    @io.send(@method, '>', 3) { |s| break s }
+    @io.lineno.should eql(2)
+
+    @io.send(@method, '>', 3) { |s| break s }
+    @io.lineno.should eql(3)
+  end
+
+  it "tries to convert the passed separator to a String using #to_str" do # TODO
+    obj = mock('to_str')
+    obj.should_receive(:to_str).and_return('>')
+
+    seen = []
+    @io.send(@method, obj, 5) { |s| seen << s }
+    seen.should == ["this>", "is>", "an>", "examp", "le"]
+  end
+
+  it "does not raise TypeError if passed separator is nil" do
+    @io.send(@method, nil, 5) { |s| break s }.should == "this>"
+  end
+
+  it "tries to convert the passed limit to an Integer using #to_int" do # TODO
+    obj = mock('to_int')
+    obj.should_receive(:to_int).and_return(5)
+
+    seen = []
+    @io.send(@method, '>', obj) { |s| seen << s }
+    seen.should == ["this>", "is>", "an>", "examp", "le"]
+  end
+end

spec/tags/library/stringio/each_line_tags.txt

@@ -1 +1,3 @@
 fails:StringIO#each_line when passed a separator yields each paragraph with all separation characters when passed an empty String as separator
+fails:StringIO#each when passed separator and limit tries to convert the passed separator to a String using #to_str
+fails:StringIO#each when passed separator and limit tries to convert the passed limit to an Integer using #to_int

spec/tags/library/stringio/each_tags.txt

@@ -1 +1,3 @@
 fails:StringIO#each when passed a separator yields each paragraph with all separation characters when passed an empty String as separator
+fails:StringIO#each when passed separator and limit tries to convert the passed separator to a String using #to_str
+fails:StringIO#each when passed separator and limit tries to convert the passed limit to an Integer using #to_int