Move rb_string_value* functions to ruby.c

* Those functions are exposed by libruby so they need to be externally visible.

Author: eregon

lib/cext/include/ruby/ruby.h

@@ -598,9 +598,15 @@ void rb_check_type(VALUE,int);
 #define Check_Type(v,t) rb_check_type((VALUE)(v),(t))
 
 VALUE rb_str_to_str(VALUE);
-MUST_INLINE VALUE rb_string_value(VALUE *value_pointer);
-MUST_INLINE char *rb_string_value_ptr(VALUE *value_pointer);
-MUST_INLINE char *rb_string_value_cstr(VALUE *value_pointer);
+#ifdef TRUFFLERUBY
+VALUE rb_string_value(VALUE *value_pointer);
+char *rb_string_value_ptr(VALUE *value_pointer);
+char *rb_string_value_cstr(VALUE *value_pointer);
+#else
+VALUE rb_string_value(volatile VALUE*);
+char *rb_string_value_ptr(volatile VALUE*);
+char *rb_string_value_cstr(volatile VALUE*);
+#endif
 
 #define StringValue(v) rb_string_value(&(v))
 #define StringValuePtr(v) rb_string_value_ptr(&(v))

lib/cext/include/truffleruby/truffleruby.h

@@ -184,30 +184,6 @@ MUST_INLINE int rb_nativethread_lock_unlock(rb_nativethread_lock_t *lock) {
   return 0;
 }
 
-MUST_INLINE VALUE rb_string_value(VALUE *value_pointer) {
-  VALUE value = *value_pointer;
-
-  if (!RB_TYPE_P(value, T_STRING)) {
-    value = rb_str_to_str(value);
-    *value_pointer = value;
-  }
-
-  return value;
-}
-
-MUST_INLINE char *rb_string_value_ptr(VALUE *value_pointer) {
-  VALUE string = rb_string_value(value_pointer);
-  return RSTRING_PTR(string);
-}
-
-MUST_INLINE char *rb_string_value_cstr(VALUE *value_pointer) {
-  VALUE string = rb_string_value(value_pointer);
-
-  RUBY_CEXT_INVOKE("rb_string_value_cstr_check", string);
-
-  return RSTRING_PTR(string);
-}
-
 MUST_INLINE int rb_tr_scan_args(int argc, VALUE *argv, const char *format, VALUE *v1, VALUE *v2, VALUE *v3, VALUE *v4, VALUE *v5, VALUE *v6, VALUE *v7, VALUE *v8, VALUE *v9, VALUE *v10) {
   // Parse the format string
 

src/main/c/cext/ruby.c

@@ -799,6 +799,26 @@ double rb_float_value(VALUE value) {
 
 // String
 
+VALUE rb_string_value(VALUE *value_pointer) {
+  VALUE value = *value_pointer;
+  if (!RB_TYPE_P(value, T_STRING)) {
+    value = rb_str_to_str(value);
+    *value_pointer = value;
+  }
+  return value;
+}
+
+char *rb_string_value_ptr(VALUE *value_pointer) {
+  VALUE string = rb_string_value(value_pointer);
+  return RSTRING_PTR(string);
+}
+
+char *rb_string_value_cstr(VALUE *value_pointer) {
+  VALUE string = rb_string_value(value_pointer);
+  RUBY_CEXT_INVOKE("rb_string_value_cstr_check", string);
+  return RSTRING_PTR(string);
+}
+
 char *RSTRING_PTR_IMPL(VALUE string) {
   return (char *)polyglot_as_i8_array(RUBY_CEXT_INVOKE_NO_WRAP("RSTRING_PTR", string));
 }