Convert CheckClassVariableNameNode to DSL inlinable node

Author: horakivo

src/main/java/org/truffleruby/core/module/ModuleNodes.java

@@ -825,7 +825,7 @@ boolean isClassVariableDefinedString(RubyModule module, Object nameObject,
                 @Cached CheckClassVariableNameNode checkClassVariableNameNode,
                 @Cached LookupClassVariableNode lookupClassVariableNode) {
             final var name = nameToJavaStringNode.execute(this, nameObject);
-            checkClassVariableNameNode.execute(module, name);
+            checkClassVariableNameNode.execute(this, module, name);
             return lookupClassVariableNode.execute(module, name) != null;
         }
 
@@ -841,7 +841,7 @@ Object getClassVariable(RubyModule module, Object nameObject,
                 @Cached LookupClassVariableNode lookupClassVariableNode,
                 @Cached InlinedConditionProfile undefinedProfile) {
             final var name = nameToJavaStringNode.execute(this, nameObject);
-            checkClassVariableNameNode.execute(module, name);
+            checkClassVariableNameNode.execute(this, module, name);
             final Object value = lookupClassVariableNode.execute(module, name);
 
             if (undefinedProfile.profile(this, value == null)) {
@@ -864,7 +864,7 @@ Object setClassVariable(RubyModule module, Object nameObject, Object value,
                 @Cached CheckClassVariableNameNode checkClassVariableNameNode,
                 @Cached SetClassVariableNode setClassVariableNode) {
             final var name = nameToJavaStringNode.execute(this, nameObject);
-            checkClassVariableNameNode.execute(module, name);
+            checkClassVariableNameNode.execute(this, module, name);
             setClassVariableNode.execute(module, name, value);
             return value;
         }
@@ -2003,7 +2003,7 @@ Object removeClassVariableString(RubyModule module, Object nameObject,
                 @Cached NameToJavaStringNode nameToJavaStringNode,
                 @Cached CheckClassVariableNameNode checkClassVariableNameNode) {
             final var name = nameToJavaStringNode.execute(this, nameObject);
-            checkClassVariableNameNode.execute(module, name);
+            checkClassVariableNameNode.execute(this, module, name);
             return ModuleOperations.removeClassVariable(module.fields, getContext(), this, name);
         }
 

src/main/java/org/truffleruby/language/objects/classvariables/CheckClassVariableNameNode.java

@@ -10,34 +10,39 @@
 package org.truffleruby.language.objects.classvariables;
 
 import com.oracle.truffle.api.dsl.Cached;
+import com.oracle.truffle.api.dsl.GenerateCached;
+import com.oracle.truffle.api.dsl.GenerateInline;
 import com.oracle.truffle.api.dsl.ImportStatic;
 import com.oracle.truffle.api.dsl.Specialization;
+import com.oracle.truffle.api.nodes.Node;
 import com.oracle.truffle.api.profiles.InlinedBranchProfile;
 import org.truffleruby.language.RubyBaseNode;
 import org.truffleruby.language.RubyDynamicObject;
 import org.truffleruby.language.control.RaiseException;
 import org.truffleruby.parser.Identifiers;
 
 @ImportStatic(Identifiers.class)
+@GenerateInline
+@GenerateCached(false)
 public abstract class CheckClassVariableNameNode extends RubyBaseNode {
 
-    public abstract void execute(RubyDynamicObject object, String name);
+    public abstract void execute(Node node, RubyDynamicObject object, String name);
 
     @Specialization(guards = { "name == cachedName", "isValidClassVariableName(cachedName)" },
             limit = "getDefaultCacheLimit()")
-    void cached(RubyDynamicObject object, String name,
+    static void cached(RubyDynamicObject object, String name,
             @Cached("name") String cachedName) {
     }
 
     @Specialization(replaces = "cached")
-    void uncached(RubyDynamicObject object, String name,
+    static void uncached(Node node, RubyDynamicObject object, String name,
             @Cached InlinedBranchProfile errorProfile) {
         if (!Identifiers.isValidClassVariableName(name)) {
-            errorProfile.enter(this);
-            throw new RaiseException(getContext(), coreExceptions().nameErrorInstanceNameNotAllowable(
+            errorProfile.enter(node);
+            throw new RaiseException(getContext(node), coreExceptions(node).nameErrorInstanceNameNotAllowable(
                     name,
                     object,
-                    this));
+                    node));
         }
     }