[GR-16589] Implement date and time related messages for RubyTime

PullRequest: truffleruby/2198

Author: eregon

CHANGELOG.md

@@ -25,6 +25,7 @@ Compatibility:
 * Add warning for `proc` without block (#2004, @ssnickolay).
 * Implemented `FrozenError#receiver`.
 * `Proc#<<` and `Proc#>>` raises TypeError if passed not callable object (#2004, @ssnickolay).
+* Support time and date related messages for `Time` (#2166).
 
 Performance:
 

spec/truffle/interop/time_spec.rb

@@ -0,0 +1,21 @@
+# Copyright (c) 2016, 2019 Oracle and/or its affiliates. All rights reserved. This
+# code is released under a tri EPL/GPL/LGPL license. You can use it,
+# redistribute it and/or modify it under the terms of the:
+#
+# Eclipse Public License version 2.0, or
+# GNU General Public License version 2, or
+# GNU Lesser General Public License version 2.1.
+
+require_relative '../../ruby/spec_helper'
+
+describe "Ruby Time instances" do
+  it "respond to interop date and time-related messages" do
+    time = Time.now
+    Truffle::Interop.should.date?(time)
+    Truffle::Interop.should.time?(time)
+    Truffle::Interop.should.time_zone?(time)
+    Truffle::Interop.should.instant?(time)
+
+    Truffle::Interop.should_not.duration?(time)
+  end
+end

src/main/java/org/truffleruby/core/time/RubyTime.java

@@ -9,14 +9,23 @@
  */
 package org.truffleruby.core.time;
 
+import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
+import com.oracle.truffle.api.interop.InteropLibrary;
+import com.oracle.truffle.api.library.ExportLibrary;
+import com.oracle.truffle.api.library.ExportMessage;
 import com.oracle.truffle.api.object.Shape;
 import org.truffleruby.core.klass.RubyClass;
 import org.truffleruby.core.string.RubyString;
 import org.truffleruby.language.Nil;
 import org.truffleruby.language.RubyDynamicObject;
 
+import java.time.Instant;
+import java.time.LocalDate;
+import java.time.LocalTime;
+import java.time.ZoneId;
 import java.time.ZonedDateTime;
 
+@ExportLibrary(InteropLibrary.class)
 public class RubyTime extends RubyDynamicObject {
 
     ZonedDateTime dateTime;
@@ -42,4 +51,45 @@ public RubyTime(
         this.isUtc = isUtc;
     }
 
+    // region Date and Time messages
+    @TruffleBoundary
+    @ExportMessage
+    public Instant asInstant() {
+        return dateTime.toInstant();
+    }
+
+    @ExportMessage
+    public boolean isDate() {
+        return true;
+    }
+
+    @TruffleBoundary
+    @ExportMessage
+    public LocalDate asDate() {
+        return dateTime.toLocalDate();
+    }
+
+    @ExportMessage
+    public boolean isTime() {
+        return true;
+    }
+
+    @TruffleBoundary
+    @ExportMessage
+    public LocalTime asTime() {
+        return dateTime.toLocalTime();
+    }
+
+    @ExportMessage
+    public boolean isTimeZone() {
+        return true;
+    }
+
+    @TruffleBoundary
+    @ExportMessage
+    public ZoneId asTimeZone() {
+        return dateTime.getZone();
+    }
+    // endregion
+
 }

src/tck/java/org/truffleruby/tck/RubyTCKLanguageProvider.java

@@ -12,10 +12,13 @@
 import static org.graalvm.polyglot.tck.TypeDescriptor.ANY;
 import static org.graalvm.polyglot.tck.TypeDescriptor.ARRAY;
 import static org.graalvm.polyglot.tck.TypeDescriptor.BOOLEAN;
+import static org.graalvm.polyglot.tck.TypeDescriptor.DATE;
 import static org.graalvm.polyglot.tck.TypeDescriptor.NULL;
 import static org.graalvm.polyglot.tck.TypeDescriptor.NUMBER;
 import static org.graalvm.polyglot.tck.TypeDescriptor.OBJECT;
 import static org.graalvm.polyglot.tck.TypeDescriptor.STRING;
+import static org.graalvm.polyglot.tck.TypeDescriptor.TIME;
+import static org.graalvm.polyglot.tck.TypeDescriptor.TIME_ZONE;
 import static org.graalvm.polyglot.tck.TypeDescriptor.array;
 import static org.graalvm.polyglot.tck.TypeDescriptor.executable;
 import static org.graalvm.polyglot.tck.TypeDescriptor.intersection;
@@ -76,6 +79,8 @@ public Collection<? extends Snippet> createValueConstructors(Context context) {
         vals.add(createValueConstructor(context, "Complex(1, 2)", OBJECT));
         vals.add(createValueConstructor(context, "'test'", STRING));
         vals.add(createValueConstructor(context, "'0123456789' + '0123456789'", STRING));
+        vals.add(createValueConstructor(context, "Time.now", DATE_TIME_ZONE));
+
         vals.add(createValueConstructor(context, "[1, 2]", NUMBER_ARRAY_OBJECT));
         vals.add(createValueConstructor(context, "[1.2, 3.4]", NUMBER_ARRAY_OBJECT));
         vals.add(createValueConstructor(context, "[1<<33, 1<<34]", NUMBER_ARRAY_OBJECT));
@@ -237,6 +242,7 @@ private Source getSource(String path) {
         }
     }
 
+    private static final TypeDescriptor DATE_TIME_ZONE = intersection(DATE, TIME, TIME_ZONE);
     private static final TypeDescriptor ARRAY_OBJECT = intersection(OBJECT, ARRAY);
     private static final TypeDescriptor NUMBER_ARRAY_OBJECT = intersection(OBJECT, array(NUMBER));