Fix formatting in Exception#full_message when RuntimeError is not handled and :highlight option is specified

Author: andrykonchin

CHANGELOG.md

@@ -37,6 +37,7 @@ Compatibility:
 * Fix `StringIO#initialize` and preserve initial string's encoding when mode is `w` so the initial string is truncated (#3599, @andrykonchin).
 * Fix `IO#{autoclose=,autoclose?}` and raise `IOError` when io is closed (@andrykonchin).
 * Fix `Thread#{thread_variable_get,thread_variable_set,thread_variable?,key?,[],[]=,fetch}` and convert a non-String/Symbol thread-local variable name to String using `#to_str` (@andrykonchin).
+* Fix formatting in `Exception#full_message` when `RuntimeError` is not handled and `highlight` option is specified (@andrykonchin).
 
 Performance:
 

spec/ruby/core/exception/full_message_spec.rb

@@ -79,6 +79,24 @@
         err.full_message(highlight: true).should !~ /unhandled exception/
         err.full_message(highlight: false).should !~ /unhandled exception/
       end
+
+      it "adds escape sequences to highlight some strings if the message is not specified and :highlight option is specified" do
+        e = RuntimeError.new("")
+
+        full_message = e.full_message(highlight: true, order: :top).lines
+        full_message[0].should.end_with? "\e[1;4munhandled exception\e[m\n"
+
+        full_message = e.full_message(highlight: true, order: :bottom).lines
+        full_message[0].should == "\e[1mTraceback\e[m (most recent call last):\n"
+        full_message[-1].should.end_with? "\e[1;4munhandled exception\e[m\n"
+
+        full_message = e.full_message(highlight: false, order: :top).lines
+        full_message[0].should.end_with? "unhandled exception\n"
+
+        full_message = e.full_message(highlight: false, order: :bottom).lines
+        full_message[0].should == "Traceback (most recent call last):\n"
+        full_message[-1].should.end_with? "unhandled exception\n"
+      end
     end
 
     describe "generic Error" do

spec/tags/core/exception/detailed_message_tags.txt

@@ -116,7 +116,7 @@ def self.detailed_message(exception, highlight)
 
       if message.empty?
         message = Primitive.equal?(exception_class, RuntimeError) ? 'unhandled exception' : class_name
-        message = "\n\e[1m#{message}\e[m" if highlight
+        message = "\e[1;4m#{message}\e[m" if highlight
         return message
       end