Make DispatchConfiguration the first argument for readability

Author: eregon

src/main/java/org/truffleruby/cext/CExtNodes.java

@@ -327,15 +327,15 @@ public Object sendWithoutCExtLock(VirtualFrame frame, Object receiver, RubySymbo
                     MutexOperations.unlockInternal(lock);
                 }
                 try {
-                    return dispatchNode.callWithFrameAndBlock(frame, receiver, method.getString(), config, block,
+                    return dispatchNode.callWithFrameAndBlock(config, frame, receiver, method.getString(), block,
                             descriptor, args);
                 } finally {
                     if (owned) {
                         MutexOperations.internalLockEvenWithException(getContext(), lock, this);
                     }
                 }
             } else {
-                return dispatchNode.callWithFrameAndBlock(frame, receiver, method.getString(), config, block,
+                return dispatchNode.callWithFrameAndBlock(config, frame, receiver, method.getString(), block,
                         descriptor, args);
             }
         }

src/main/java/org/truffleruby/core/array/ArrayConvertNode.java

@@ -33,7 +33,7 @@ protected RubyArray cast(Object object,
             @Cached ConditionProfile canCast,
             @Cached ArrayBuilderNode arrayBuilder,
             @Cached DispatchNode toArrayNode) {
-        final Object result = toArrayNode.call(object, "to_ary", PRIVATE_RETURN_MISSING);
+        final Object result = toArrayNode.call(PRIVATE_RETURN_MISSING, object, "to_ary");
         if (canCast.profile(result instanceof RubyArray)) {
             return (RubyArray) result;
         } else {

src/main/java/org/truffleruby/core/array/ArrayNodes.java

@@ -1438,7 +1438,7 @@ private Object injectSymbolHelper(VirtualFrame frame, RubyArray array, String sy
             int n = start;
             try {
                 for (; loopProfile.inject(n < arraySizeProfile.profile(array.size)); n++) {
-                    accumulator = dispatch.callWithFrame(frame, accumulator, symbol, PUBLIC, stores.read(store, n));
+                    accumulator = dispatch.callWithFrame(PUBLIC, frame, accumulator, symbol, stores.read(store, n));
                     TruffleSafepoint.poll(this);
                 }
             } finally {

src/main/java/org/truffleruby/core/cast/HashCastNode.java

@@ -38,7 +38,7 @@ protected RubyHash castHash(RubyHash hash) {
     protected RubyHash cast(Object object,
             @Cached InlinedBranchProfile errorProfile,
             @Cached DispatchNode toHashNode) {
-        final Object result = toHashNode.call(object, "to_hash", PRIVATE_RETURN_MISSING);
+        final Object result = toHashNode.call(PRIVATE_RETURN_MISSING, object, "to_hash");
 
         if (result == DispatchNode.MISSING) {
             errorProfile.enter(this);

src/main/java/org/truffleruby/core/cast/SplatCastNode.java

@@ -121,7 +121,7 @@ private Object callToA(Object nil) {
             CompilerDirectives.transferToInterpreterAndInvalidate();
             toA = insert(DispatchNode.create());
         }
-        return toA.call(nil, "to_a", PRIVATE_RETURN_MISSING);
+        return toA.call(PRIVATE_RETURN_MISSING, nil, "to_a");
     }
 
     private RubyArray executeDup(RubyArray array) {

src/main/java/org/truffleruby/core/format/convert/ToLongNode.java

@@ -82,7 +82,7 @@ protected static long toLong(VirtualFrame frame, Object object,
             @Cached InlinedBranchProfile noConversionAvailable,
             @Bind("this") Node node) {
 
-        Object result = toIntNode.call(object, "to_int", PRIVATE_RETURN_MISSING);
+        Object result = toIntNode.call(PRIVATE_RETURN_MISSING, object, "to_int");
         if (result == DispatchNode.MISSING) {
             noConversionAvailable.enter(node);
             throw new CantConvertException("can't convert Object to Integer");

src/main/java/org/truffleruby/core/format/convert/ToStringNode.java

@@ -110,7 +110,7 @@ protected Object toStringString(Object string,
             @Cached @Shared RubyStringLibrary libString,
             @Cached @Exclusive RubyStringLibrary argLibString) {
         if ("inspect".equals(conversionMethod)) {
-            final Object value = getToStrNode().call(string, conversionMethod, PRIVATE_RETURN_MISSING);
+            final Object value = getToStrNode().call(PRIVATE_RETURN_MISSING, string, conversionMethod);
 
             if (libString.isRubyString(value)) {
                 return value;
@@ -129,7 +129,7 @@ protected Object toString(RubyArray array,
             toSNode = insert(DispatchNode.create());
         }
 
-        final Object value = toSNode.call(array, "to_s", PRIVATE_RETURN_MISSING);
+        final Object value = toSNode.call(PRIVATE_RETURN_MISSING, array, "to_s");
 
         if (libString.isRubyString(value)) {
             return value;
@@ -142,7 +142,7 @@ protected Object toString(RubyArray array,
             guards = { "isNotRubyString(object)", "!isRubyArray(object)", "!isForeignObject(object)" })
     protected Object toString(Object object,
             @Cached @Shared RubyStringLibrary libString) {
-        final Object value = getToStrNode().call(object, conversionMethod, PRIVATE_RETURN_MISSING);
+        final Object value = getToStrNode().call(PRIVATE_RETURN_MISSING, object, conversionMethod);
 
         if (libString.isRubyString(value)) {
             return value;

src/main/java/org/truffleruby/language/ImmutableRubyObject.java

@@ -147,7 +147,7 @@ public Object invokeMember(String name, Object[] arguments,
             @Shared @Cached BranchProfile errorProfile)
             throws UnknownIdentifierException {
         Object[] convertedArguments = foreignToRubyArgumentsNode.executeConvert(arguments);
-        Object result = dispatchMember.call(this, name, PRIVATE_RETURN_MISSING, convertedArguments);
+        Object result = dispatchMember.call(PRIVATE_RETURN_MISSING, this, name, convertedArguments);
         if (result == DispatchNode.MISSING) {
             errorProfile.enter();
             throw UnknownIdentifierException.create(name);