CheckIndexNode is DSL inlinable

Author: horakivo

src/main/java/org/truffleruby/core/string/StringHelperNodes.java

@@ -417,28 +417,30 @@ protected Object getAssociatedImmutable(ImmutableRubyString string) {
 
     }
 
+    @GenerateInline
+    @GenerateCached(false)
     public abstract static class CheckIndexNode extends RubyBaseNode {
 
-        public abstract int executeCheck(int index, int length);
+        public abstract int execute(Node node, int index, int length);
 
         @Specialization
-        protected int checkIndex(int index, int length,
+        protected static int checkIndex(Node node, int index, int length,
                 @Cached InlinedConditionProfile negativeIndexProfile,
                 @Cached InlinedBranchProfile errorProfile) {
             if (index >= length) {
-                errorProfile.enter(this);
+                errorProfile.enter(node);
                 throw new RaiseException(
-                        getContext(),
-                        getContext().getCoreExceptions().indexErrorOutOfString(index, this));
+                        getContext(node),
+                        getContext(node).getCoreExceptions().indexErrorOutOfString(index, node));
             }
 
-            if (negativeIndexProfile.profile(this, index < 0)) {
+            if (negativeIndexProfile.profile(node, index < 0)) {
                 index += length;
                 if (index < 0) {
-                    errorProfile.enter(this);
+                    errorProfile.enter(node);
                     throw new RaiseException(
-                            getContext(),
-                            getContext().getCoreExceptions().indexErrorOutOfString(index, this));
+                            getContext(node),
+                            getContext(node).getCoreExceptions().indexErrorOutOfString(index, node));
                 }
             }
 

src/main/java/org/truffleruby/core/string/StringNodes.java

@@ -2268,27 +2268,27 @@ public abstract static class SetByteNode extends RubyBaseNode {
         public abstract int execute(Node node, RubyString string, int index, int value);
 
         @Specialization(guards = "tstring.isMutable()")
-        protected static int mutable(RubyString string, int index, int value,
+        protected static int mutable(Node node, RubyString string, int index, int value,
                 @Cached @Shared StringHelperNodes.CheckIndexNode checkIndexNode,
                 @Cached @Shared RubyStringLibrary libString,
                 @Bind("string.tstring") AbstractTruffleString tstring,
                 @Cached @Shared MutableTruffleString.WriteByteNode writeByteNode) {
             var tencoding = libString.getTEncoding(string);
-            final int normalizedIndex = checkIndexNode.executeCheck(index, tstring.byteLength(tencoding));
+            final int normalizedIndex = checkIndexNode.execute(node, index, tstring.byteLength(tencoding));
 
             writeByteNode.execute((MutableTruffleString) tstring, normalizedIndex, (byte) value, tencoding);
             return value;
         }
 
         @Specialization(guards = "!tstring.isMutable()")
-        protected static int immutable(RubyString string, int index, int value,
+        protected static int immutable(Node node, RubyString string, int index, int value,
                 @Cached @Shared StringHelperNodes.CheckIndexNode checkIndexNode,
                 @Cached @Shared RubyStringLibrary libString,
                 @Bind("string.tstring") AbstractTruffleString tstring,
                 @Cached MutableTruffleString.AsMutableTruffleStringNode asMutableTruffleStringNode,
                 @Cached @Shared MutableTruffleString.WriteByteNode writeByteNode) {
             var tencoding = libString.getTEncoding(string);
-            final int normalizedIndex = checkIndexNode.executeCheck(index, tstring.byteLength(tencoding));
+            final int normalizedIndex = checkIndexNode.execute(node, index, tstring.byteLength(tencoding));
 
             MutableTruffleString mutableTString = asMutableTruffleStringNode.execute(tstring, tencoding);
             writeByteNode.execute(mutableTString, normalizedIndex, (byte) value, tencoding);