[GR-14806] Update specs

PullRequest: truffleruby/3672

Author: eregon

spec/mspec/spec/helpers/ruby_exe_spec.rb

@@ -145,7 +145,7 @@ class RubyExeSpecs
     stub_const 'RUBY_EXE', 'ruby_spec_exe -w -Q'
 
     @script = RubyExeSpecs.new
-    allow(@script).to receive(:`).and_return('OUTPUT')
+    allow(IO).to receive(:popen).and_return('OUTPUT')
 
     status_successful = double(Process::Status, exited?: true, exitstatus: 0)
     allow(Process).to receive(:last_status).and_return(status_successful)
@@ -155,7 +155,7 @@ class RubyExeSpecs
     code = "code"
     options = {}
     output = "output"
-    allow(@script).to receive(:`).and_return(output)
+    expect(IO).to receive(:popen).and_return(output)
 
     expect(@script.ruby_exe(code, options)).to eq output
   end
@@ -168,7 +168,7 @@ class RubyExeSpecs
     code = "code"
     options = {}
     expect(@script).to receive(:ruby_cmd).and_return("ruby_cmd")
-    expect(@script).to receive(:`).with("ruby_cmd")
+    expect(IO).to receive(:popen).with("ruby_cmd")
     @script.ruby_exe(code, options)
   end
 
@@ -227,7 +227,7 @@ class RubyExeSpecs
       expect(ENV).to receive(:[]=).with("ABC", "xyz")
       expect(ENV).to receive(:[]=).with("ABC", "123")
 
-      expect(@script).to receive(:`).and_raise(Exception)
+      expect(IO).to receive(:popen).and_raise(Exception)
       expect do
         @script.ruby_exe nil, :env => { :ABC => "xyz" }
       end.to raise_error(Exception)
@@ -248,7 +248,7 @@ class RubyExeSpecs
 
     it "does not raise exception when command ends with expected status" do
       output = "output"
-      allow(@script).to receive(:`).and_return(output)
+      expect(IO).to receive(:popen).and_return(output)
 
       expect(@script.ruby_exe("path", exit_status: 4)).to eq output
     end

spec/mspec/tool/check_require_spec_helper.rb

@@ -0,0 +1,34 @@
+#!/usr/bin/env ruby
+
+# This script is used to check that each *_spec.rb file has
+# a relative_require for spec_helper which should live higher
+# up in the ruby/spec repo directory tree.
+#
+# Prints errors to $stderr and returns a non-zero exit code when
+# errors are found.
+#
+# Related to https://github.com/ruby/spec/pull/992
+
+def check_file(fn)
+  File.foreach(fn) do |line|
+    return $1 if line =~ /^\s*require_relative\s*['"](.*spec_helper)['"]/
+  end
+  nil
+end
+
+rootdir = ARGV[0] || "."
+fglob = File.join(rootdir, "**", "*_spec.rb")
+specfiles = Dir.glob(fglob)
+raise "No spec files found in #{fglob.inspect}. Give an argument to specify the root-directory of ruby/spec" if specfiles.empty?
+
+errors = 0
+specfiles.sort.each do |fn|
+  result = check_file(fn)
+  if result.nil?
+    warn "Missing require_relative for *spec_helper for file: #{fn}"
+    errors += 1
+  end
+end
+
+puts "# Found #{errors} files with require_relative spec_helper issues."
+exit 1 if errors > 0

spec/ruby/core/array/all_spec.rb

@@ -2,7 +2,7 @@
 require_relative 'shared/iterable_and_tolerating_size_increasing'
 
 describe "Array#all?" do
-  @value_to_return = -> (_) { true }
+  @value_to_return = -> _ { true }
   it_behaves_like :array_iterable_and_tolerating_size_increasing, :all?
 
   it "ignores the block if there is an argument" do

spec/ruby/core/array/any_spec.rb

@@ -20,7 +20,7 @@
   end
 
   describe 'with a block given' do
-    @value_to_return = -> (_) { false }
+    @value_to_return = -> _ { false }
     it_behaves_like :array_iterable_and_tolerating_size_increasing, :any?
 
     it 'is false if the array is empty' do

spec/ruby/core/array/delete_if_spec.rb

@@ -77,6 +77,6 @@
   it_behaves_like :enumeratorized_with_origin_size, :delete_if, [1,2,3]
   it_behaves_like :delete_if, :delete_if
 
-  @value_to_return = -> (_) { false }
+  @value_to_return = -> _ { false }
   it_behaves_like :array_iterable_and_tolerating_size_increasing, :delete_if
 end

spec/ruby/core/array/drop_while_spec.rb

@@ -3,7 +3,7 @@
 require_relative 'shared/iterable_and_tolerating_size_increasing'
 
 describe "Array#drop_while" do
-  @value_to_return = -> (_) { true }
+  @value_to_return = -> _ { true }
   it_behaves_like :array_iterable_and_tolerating_size_increasing, :drop_while
 
   it "removes elements from the start of the array while the block evaluates to true" do

spec/ruby/core/array/each_index_spec.rb

@@ -5,7 +5,7 @@
 
 # Modifying a collection while the contents are being iterated
 # gives undefined behavior. See
-# http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/23633
+# https://blade.ruby-lang.org/ruby-core/23633
 
 describe "Array#each_index" do
   before :each do

spec/ruby/core/array/fill_spec.rb

@@ -211,7 +211,7 @@
     [1, 2, 3, 4, 5].fill(-2, -2, &@never_passed).should == [1, 2, 3, 4, 5]
   end
 
-  # See: http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/17481
+  # See: https://blade.ruby-lang.org/ruby-core/17481
   it "does not raise an exception if the given length is negative and its absolute value does not exceed the index" do
     -> { [1, 2, 3, 4].fill('a', 3, -1)}.should_not raise_error(ArgumentError)
     -> { [1, 2, 3, 4].fill('a', 3, -2)}.should_not raise_error(ArgumentError)

spec/ruby/core/array/none_spec.rb

@@ -2,7 +2,7 @@
 require_relative 'shared/iterable_and_tolerating_size_increasing'
 
 describe "Array#none?" do
-  @value_to_return = -> (_) { false }
+  @value_to_return = -> _ { false }
   it_behaves_like :array_iterable_and_tolerating_size_increasing, :none?
 
   it "ignores the block if there is an argument" do

spec/ruby/core/array/one_spec.rb

@@ -2,7 +2,7 @@
 require_relative 'shared/iterable_and_tolerating_size_increasing'
 
 describe "Array#one?" do
-  @value_to_return = -> (_) { false }
+  @value_to_return = -> _ { false }
   it_behaves_like :array_iterable_and_tolerating_size_increasing, :one?
 
   it "ignores the block if there is an argument" do