[GR-20446] Update taint to noop and warn when used in verbose mode

PullRequest: truffleruby/2175

Author: bjfish

lib/truffle/pathname.rb

@@ -223,12 +223,20 @@ def initialize(path)
 
     @path = path.dup
 
-    self.taint if @path.tainted?
+    self
   end
 
   def freeze() super; @path.freeze; self end
-  def taint() super; @path.taint; self end
-  def untaint() super; @path.untaint; self end
+
+  def taint
+    warn 'Pathname#taint is deprecated and will be removed in Ruby 3.2.', uplevel: 1 if $VERBOSE
+    self
+  end
+
+  def untaint
+    warn 'Pathname#untaint is deprecated and will be removed in Ruby 3.2.', uplevel: 1 if $VERBOSE
+    self
+  end
 
   #
   # Compare this pathname with +other+.  The comparison is string-based.

lib/truffle/stringio.rb

@@ -96,8 +96,6 @@ def initialize(string=nil, mode=nil)
   def initialize_copy(from)
     from = Truffle::Type.coerce_to(from, StringIO, :to_strio)
 
-    taint if from.tainted?
-
     @append = from.instance_variable_get(:@append)
     @readable = from.instance_variable_get(:@readable)
     @writable = from.instance_variable_get(:@writable)
@@ -232,7 +230,6 @@ def write(str)
       end
       Primitive.string_splice(string, str, pos, stop, string.encoding)
       d.pos += str.bytesize
-      string.taint if str.tainted?
     end
 
     str.bytesize
@@ -467,7 +464,6 @@ def reopen(string=nil, mode=Undefined)
     if string and not string.kind_of? String and mode.equal? Undefined
       stringio = Truffle::Type.coerce_to(string, StringIO, :to_strio)
 
-      taint if stringio.tainted?
       initialize_copy stringio
     else
       mode = nil if mode.equal? Undefined

lib/truffle/strscan.rb

@@ -78,7 +78,6 @@ def [](n)
     if @match
       raise TypeError, "no implicit conversion of #{n.class} into Integer" if Range === n
       str = @match[n]
-      str.taint if @string.tainted?
       str
     end
   end
@@ -174,7 +173,6 @@ def inspect
         end
       end
 
-      str.taint if @string.tainted?
       str
     else
       "#<#{self.class} (uninitialized)>"
@@ -188,7 +186,6 @@ def match?(pattern)
   def matched
     if @match
       matched = @match.to_s
-      matched.taint if @string.tainted?
       matched
     end
   end

lib/truffle/truffle/cext.rb

@@ -270,10 +270,6 @@ def RB_OBJ_TAINTABLE(object)
     end
   end
 
-  def rb_tr_obj_infect(dest, source)
-    Primitive.infect(dest, source)
-  end
-
   FREEZE_METHOD = Kernel.instance_method :freeze
 
   def rb_obj_freeze(obj)
@@ -678,7 +674,7 @@ def rb_cstr_to_dbl(string, badcheck)
 
   def rb_str_new_native(pointer, length)
     raise "#{pointer} not a pointer" unless Truffle::Interop.pointer?(pointer)
-    Truffle::FFI::Pointer.new(pointer).read_string(length).untaint
+    Truffle::FFI::Pointer.new(pointer).read_string(length)
   end
 
   def rb_enc_str_coderange(str)

lib/truffle/truffle/cext_structs.rb

@@ -158,7 +158,6 @@ def set_user_flags(flags)
   def compute_flags
     flags = 0
     flags |= RUBY_FL_FREEZE if @object.frozen?
-    flags |= RUBY_FL_TAINT  if @object.tainted?
     flags | user_flags
   end
 
@@ -194,10 +193,7 @@ def flags_to_string(flags)
 
   def set_flags(flags)
     if flags & RUBY_FL_TAINT != 0
-      @object.taint
       flags &= ~RUBY_FL_TAINT
-    elsif @object.tainted?
-      @object.untaint
     end
 
     set_user_flags(flags & USER_FLAGS_MASK)

lib/truffle/truffle/fiddle_backend.rb

@@ -319,7 +319,6 @@ def self.to_ptr(val)
       else
         ptr = Pointer.new(Integer(val))
       end
-      Primitive.infect ptr, val
       ptr
     end