Skip to content

Commit 0b4a378

Browse files
committed
Update FFI docs
1 parent d6ec8c9 commit 0b4a378

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

doc/contributor/ffi.md

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,12 @@ require C extension support for gems using FFI.
2727

2828
## Synchronization
2929

30-
I use a branch `truffleruby-specs-$FFI_RELEASE` on my fork https://github.com/eregon/ffi
31-
which keeps our modifications on top of the FFI release tag we are based on.
32-
`tool/import-ffi.sh` from the latest of these branches should synchronize cleanly.
30+
`tool/import-ffi.sh` from the corresponding FFI version should synchronize cleanly.
3331

34-
In general, changes are done in TruffleRuby first, then I add them to my local `ffi` repository
35-
in the `truffleruby-specs-$FFI_RELEASE` branch with `git cherry-pick`.
36-
This requires `truffleruby` to be added as a remote to the `ffi` repo:
37-
```bash
38-
git remote add truffleruby ../truffleruby-ws/truffleruby
39-
```
32+
In general, changes are done in `ffi` first, and I copy them to truffleruby via `tool/import-ffi.sh` while working on them.
33+
We should upstream all changes we do to `ffi`.
4034

41-
From there we should of course upstream as many changes as possible to minimize the diff.
35+
The only diff we should have is in `src/main/ruby/truffleruby/core/truffle/ffi/pointer_extra.rb` and it should remain small.
4236

4337
## Running Specs in Upstream FFI Repository
4438

0 commit comments

Comments
 (0)