Ensure all ImmutableRubyString are interned

Author: eregon

src/main/java/org/truffleruby/core/CoreLibrary.java

@@ -740,7 +740,7 @@ private ImmutableRubyString frozenUSASCIIString(String string) {
         // NOTE(norswap, Nov. 2nd 2020): Okay for language access to be slow, currently only used during initialization.
         final LeafRope rope = language.ropeCache.getRope(
                 StringOperations.encodeRope(string, USASCIIEncoding.INSTANCE, CodeRange.CR_7BIT));
-        return StringOperations.createFrozenString(rope);
+        return language.getFrozenStringLiteral(rope);
     }
 
     private RubyClass defineClass(String name) {

src/main/java/org/truffleruby/core/encoding/EncodingManager.java

@@ -36,7 +36,6 @@
 import org.truffleruby.core.rope.Rope;
 import org.truffleruby.core.rope.RopeOperations;
 import org.truffleruby.core.string.EncodingUtils;
-import org.truffleruby.core.string.StringOperations;
 import org.truffleruby.extra.ffi.Pointer;
 import org.truffleruby.language.ImmutableRubyString;
 import org.truffleruby.platform.NativeConfiguration;
@@ -183,11 +182,11 @@ private RubyEncoding newRubyEncoding(Encoding encoding, byte[] name, int p, int
                 "; name.length = " + name.length + ")";
 
         final Rope rope = RopeOperations.create(name, USASCIIEncoding.INSTANCE, CodeRange.CR_7BIT);
-        final LeafRope cachedRope = context.getLanguageSlow().ropeCache.getRope(
+        final LeafRope cachedRope = language.ropeCache.getRope(
                 rope.getBytes(),
                 rope.getEncoding(),
                 rope.getCodeRange());
-        final ImmutableRubyString string = StringOperations.createFrozenString(cachedRope);
+        final ImmutableRubyString string = language.getFrozenStringLiteral(cachedRope);
 
         final RubyEncoding instance = new RubyEncoding(
                 context.getCoreLibrary().encodingClass,

src/main/java/org/truffleruby/core/string/FrozenStringLiterals.java

@@ -23,7 +23,7 @@ public ImmutableRubyString getFrozenStringLiteral(LeafRope rope) {
         if (string != null) {
             return string;
         } else {
-            return values.addInCacheIfAbsent(rope, StringOperations.createFrozenString(rope));
+            return values.addInCacheIfAbsent(rope, new ImmutableRubyString(rope));
         }
     }
 

src/main/java/org/truffleruby/core/string/StringOperations.java

@@ -48,7 +48,6 @@
 import org.truffleruby.core.rope.RopeOperations;
 
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
-import org.truffleruby.language.ImmutableRubyString;
 import org.truffleruby.language.RubyContextSourceNode;
 import org.truffleruby.language.objects.AllocationTracing;
 
@@ -74,11 +73,6 @@ public static RubyString createString(RubyContext context, RubyLanguage language
         return instance;
     }
 
-    // TODO BJF Aug-3-2020 Trace more allocations of RubyString
-    public static ImmutableRubyString createFrozenString(LeafRope rope) {
-        return new ImmutableRubyString(rope);
-    }
-
     public static int clampExclusiveIndex(int length, int index) {
         return ArrayOperations.clampExclusiveIndex(length, index);
     }

src/main/java/org/truffleruby/language/ImmutableRubyString.java

@@ -22,11 +22,13 @@
 import org.truffleruby.core.rope.LeafRope;
 import org.truffleruby.core.rope.Rope;
 import org.truffleruby.core.rope.RopeOperations;
+import org.truffleruby.core.string.FrozenStringLiterals;
 import org.truffleruby.interop.ToJavaStringNode;
 import org.truffleruby.language.dispatch.DispatchNode;
 import org.truffleruby.language.library.RubyStringLibrary;
 
-
+/** All ImmutableRubyString are interned and must be created through
+ * {@link FrozenStringLiterals#getFrozenStringLiteral(LeafRope)}. */
 @ExportLibrary(InteropLibrary.class)
 @ExportLibrary(RubyStringLibrary.class)
 public class ImmutableRubyString extends ImmutableRubyObject implements TruffleObject {