Fix TCPServer#accept to set #do_not_reverse_lookup correctly on the created TCPSocket

Author: eregon

CHANGELOG.md

@@ -14,6 +14,7 @@ Bug fixes:
 * Implemented `FFI::Pointer#clear` (#1687).
 * Procs will now yield to the block in their declaration context even when called with a block argument (#1657).
 * Fixed problems with calling POSIX methods if `Symbol#[]` is redefined (#1665).
+* Fix `TCPServer#accept` to set `#do_not_reverse_lookup` correctly on the created `TCPSocket`.
 
 Compatibility
 

lib/truffle/socket/basic_socket.rb

@@ -25,10 +25,10 @@
 # EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 class BasicSocket < IO
-  def self.for_fd(fixnum)
+  def self.for_fd(fd)
     sock = allocate
 
-    IO.setup(sock, fixnum, nil, true)
+    IO.setup(sock, fd, nil, true)
     sock.binmode
     # TruffleRuby: start
     sock.do_not_reverse_lookup = do_not_reverse_lookup

lib/truffle/socket/truffle.rb

@@ -81,10 +81,7 @@ def self.accept(source, new_class)
 
         Error.read_error('accept(2)', source) if fd < 0
 
-        socket = new_class.allocate
-
-        ::IO.setup(socket, fd, nil, true)
-        socket.binmode
+        socket = new_class.for_fd(fd)
 
         socktype = source.getsockopt(:SOCKET, :TYPE).int
         addrinfo = Addrinfo.new(sockaddr.to_s, sockaddr.family, socktype)