Skip to content

Commit 349a91e

Browse files
sagarp337NagendraNigade
authored andcommitted
Bug Fix - Added Resource discovery support for datascience model resource
1 parent 888492e commit 349a91e

File tree

2 files changed

+27
-8
lines changed

2 files changed

+27
-8
lines changed

internal/integrationtest/datascience_model_test.go

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,14 @@ var (
3737
}
3838

3939
DatascienceDatascienceModelDataSourceRepresentation = map[string]interface{}{
40-
"compartment_id": acctest.Representation{RepType: acctest.Required, Create: `${var.compartment_id}`},
41-
"display_name": acctest.Representation{RepType: acctest.Optional, Create: `displayName`, Update: `displayName2`},
42-
"id": acctest.Representation{RepType: acctest.Optional, Create: `${oci_datascience_model.test_model.id}`},
43-
"project_id": acctest.Representation{RepType: acctest.Optional, Create: `${oci_datascience_project.test_project.id}`},
44-
"state": acctest.Representation{RepType: acctest.Optional, Create: `ACTIVE`},
45-
"filter": acctest.RepresentationGroup{RepType: acctest.Required, Group: DatascienceModelDataSourceFilterRepresentation}}
40+
"compartment_id": acctest.Representation{RepType: acctest.Required, Create: `${var.compartment_id}`},
41+
"display_name": acctest.Representation{RepType: acctest.Optional, Create: `displayName`, Update: `displayName2`},
42+
"id": acctest.Representation{RepType: acctest.Optional, Create: `${oci_datascience_model.test_model.id}`},
43+
"model_version_set_name": acctest.Representation{RepType: acctest.Optional, Create: ``},
44+
"project_id": acctest.Representation{RepType: acctest.Optional, Create: `${oci_datascience_project.test_project.id}`},
45+
"state": acctest.Representation{RepType: acctest.Optional, Create: `ACTIVE`},
46+
"version_label": acctest.Representation{RepType: acctest.Optional, Create: ``, Update: ``},
47+
"filter": acctest.RepresentationGroup{RepType: acctest.Required, Group: DatascienceModelDataSourceFilterRepresentation}}
4648
DatascienceModelDataSourceFilterRepresentation = map[string]interface{}{
4749
"name": acctest.Representation{RepType: acctest.Required, Create: `id`},
4850
"values": acctest.Representation{RepType: acctest.Required, Create: []string{`${oci_datascience_model.test_model.id}`}},
@@ -76,6 +78,10 @@ var (
7678

7779
DatascienceModelResourceDependencies = acctest.GenerateResourceFromRepresentationMap("oci_datascience_project", "test_project", acctest.Required, acctest.Create, DatascienceProjectRepresentation) +
7880
DefinedTagsDependencies
81+
82+
DatascienceModelResourceModelVersionSetDependencies = acctest.GenerateResourceFromRepresentationMap("oci_datascience_model_version_set", "test_model_version_set", acctest.Required, acctest.Create, DatascienceModelVersionSetRepresentation) +
83+
acctest.GenerateResourceFromRepresentationMap("oci_datascience_project", "test_project", acctest.Required, acctest.Create, DatascienceProjectRepresentation) +
84+
DefinedTagsDependencies
7985
)
8086

8187
// issue-routing-tag: datascience/default
@@ -241,11 +247,12 @@ func TestDatascienceModelResource_basic(t *testing.T) {
241247
{
242248
Config: config +
243249
acctest.GenerateDataSourceFromRepresentationMap("oci_datascience_models", "test_models", acctest.Optional, acctest.Update, DatascienceDatascienceModelDataSourceRepresentation) +
244-
compartmentIdVariableStr + DatascienceModelResourceDependencies +
250+
compartmentIdVariableStr + DatascienceModelResourceModelVersionSetDependencies +
245251
acctest.GenerateResourceFromRepresentationMap("oci_datascience_model", "test_model", acctest.Optional, acctest.Update, DatascienceModelRepresentation),
246252
Check: acctest.ComposeAggregateTestCheckFuncWrapper(
247253
resource.TestCheckResourceAttr(datasourceName, "compartment_id", compartmentId),
248254
resource.TestCheckResourceAttr(datasourceName, "display_name", "displayName2"),
255+
resource.TestCheckResourceAttrSet(datasourceName, "id"),
249256
resource.TestCheckResourceAttrSet(datasourceName, "project_id"),
250257
resource.TestCheckResourceAttr(datasourceName, "state", "ACTIVE"),
251258

@@ -398,4 +405,4 @@ func DatascienceModelSweepResponseFetchOperation(client *tf_client.OracleClients
398405
},
399406
})
400407
return err
401-
}
408+
}

internal/service/datascience/datascience_export.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,17 @@ var exportDatascienceJobRunHints = &tf_export.TerraformResourceHints{
9595
},
9696
}
9797

98+
var exportDatascienceModelVersionSetHints = &tf_export.TerraformResourceHints{
99+
ResourceClass: "oci_datascience_model_version_set",
100+
DatasourceClass: "oci_datascience_model_version_sets",
101+
DatasourceItemsAttr: "model_version_sets",
102+
ResourceAbbreviation: "model_version_set",
103+
RequireResourceRefresh: true,
104+
DiscoverableLifecycleStates: []string{
105+
string(oci_datascience.ModelVersionSetLifecycleStateActive),
106+
},
107+
}
108+
98109
var exportDatasciencePipelineRunHints = &tf_export.TerraformResourceHints{
99110
ResourceClass: "oci_datascience_pipeline_run",
100111
DatasourceClass: "oci_datascience_pipeline_runs",
@@ -126,6 +137,7 @@ var datascienceResourceGraph = tf_export.TerraformResourceGraph{
126137
{TerraformResourceHints: exportDatascienceJobHints},
127138
{TerraformResourceHints: exportDatascienceJobRunHints},
128139
{TerraformResourceHints: exportDatasciencePipelineRunHints},
140+
{TerraformResourceHints: exportDatascienceModelVersionSetHints},
129141
{TerraformResourceHints: exportDatasciencePipelineHints},
130142
},
131143
"oci_datascience_model": {

0 commit comments

Comments
 (0)