Skip to content

Commit d4813b9

Browse files
Remove ambiguity on region Provider bean
Removing 2.7.x from support matrix in main readme
1 parent c861af3 commit d4813b9

File tree

6 files changed

+28
-10
lines changed

6 files changed

+28
-10
lines changed

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
> **Warning**
66
>
77
> Code in this repository is work-in-progress and has not been released officially.
8-
>
8+
>
99
> Not recommended for personal or production use at this point.
1010
1111
## Introduction
@@ -19,7 +19,7 @@ For a deep dive into the project, refer to the Spring Cloud OCI documentation:
1919

2020
| Version | Reference Docs | API Docs |
2121
|------------------------|---------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------|
22-
| Spring Cloud OCI 1.0.0 | [Reference Docs](https://oracle.github.io/spring-cloud-oci/1.0.0/reference/html/index.html) | [API Docs](https://oracle.github.io/spring-cloud-oci/1.0.0/javadocs/index.html) |
22+
| Spring Cloud OCI 1.0.0 | [Reference Docs](https://oracle.github.io/spring-cloud-oci/1.0.0/reference/html/index.html) | [API Docs](https://oracle.github.io/spring-cloud-oci/1.0.0/javadocs/index.html) |
2323

2424

2525
## Compatibility with Spring Project Versions
@@ -28,7 +28,7 @@ This project has dependency and transitive dependencies on Spring Projects. The
2828

2929
| Spring Cloud OCI | Spring Cloud | Spring Boot | OCI Java SDK |
3030
|-------------------|-----------------|---------------------|--------------|
31-
| 1.0.0 | <to-be-checked> | 2.7.x, 3.0.x, 3.1.x | 3.19.0 |
31+
| 1.0.0 | <to-be-checked> | 3.0.x, 3.1.x | 3.19.0 |
3232

3333

3434
## Try out samples
@@ -102,4 +102,3 @@ Copyright (c) 2023 Oracle and/or its affiliates.
102102

103103
Released under the Universal Permissive License v1.0 as shown at
104104
<https://oss.oracle.com/licenses/upl/>.
105-

spring-cloud-oci-autoconfigure/src/main/java/com/oracle/cloud/spring/autoconfigure/core/CredentialsProviderAutoConfiguration.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
@EnableConfigurationProperties(CredentialsProperties.class)
3030
public class CredentialsProviderAutoConfiguration {
3131

32+
public static final String credentialsProviderQualifier = "credentialsProvider";
33+
3234
private static final String PROFILE_DEFAULT = "DEFAULT";
3335
private final CredentialsProperties properties;
3436

@@ -41,7 +43,7 @@ public CredentialsProviderAutoConfiguration(CredentialsProperties properties) {
4143
* @return
4244
* @throws IOException
4345
*/
44-
@Bean
46+
@Bean (name = credentialsProviderQualifier)
4547
@ConditionalOnMissingBean
4648
public BasicAuthenticationDetailsProvider credentialsProvider() throws IOException {
4749
return createCredentialsProvider(properties);

spring-cloud-oci-autoconfigure/src/main/java/com/oracle/cloud/spring/autoconfigure/core/RegionProviderAutoConfiguration.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,14 @@
2222
@EnableConfigurationProperties(RegionProperties.class)
2323
public class RegionProviderAutoConfiguration {
2424

25+
public static final String regionProviderQualifier = "regionProvider";
2526
private final RegionProperties properties;
2627

2728
public RegionProviderAutoConfiguration(RegionProperties properties) {
2829
this.properties = properties;
2930
}
3031

31-
@Bean
32+
@Bean (name = regionProviderQualifier)
3233
@ConditionalOnMissingBean
3334
public RegionProvider regionProvider() {
3435
return createRegionProvider(properties);

spring-cloud-oci-autoconfigure/src/main/java/com/oracle/cloud/spring/logging/LoggingAutoConfiguration.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,17 @@
88
import com.oracle.bmc.auth.BasicAuthenticationDetailsProvider;
99
import com.oracle.bmc.auth.RegionProvider;
1010
import com.oracle.bmc.loggingingestion.LoggingClient;
11+
import org.springframework.beans.factory.annotation.Qualifier;
1112
import org.springframework.boot.autoconfigure.AutoConfiguration;
1213
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
1314
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
1415
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
1516
import org.springframework.boot.context.properties.EnableConfigurationProperties;
1617
import org.springframework.context.annotation.Bean;
1718

19+
import static com.oracle.cloud.spring.autoconfigure.core.CredentialsProviderAutoConfiguration.credentialsProviderQualifier;
20+
import static com.oracle.cloud.spring.autoconfigure.core.RegionProviderAutoConfiguration.regionProviderQualifier;
21+
1822
/**
1923
* Auto-configuration for initializing the OCI Logging component.
2024
* Depends on {@link com.oracle.cloud.spring.autoconfigure.core.CredentialsProviderAutoConfiguration} and
@@ -43,7 +47,8 @@ Logging getLoggingImpl(com.oracle.bmc.loggingingestion.Logging logging) {
4347

4448
@Bean
4549
@ConditionalOnMissingBean
46-
com.oracle.bmc.loggingingestion.Logging loggingClient(RegionProvider regionProvider,
50+
com.oracle.bmc.loggingingestion.Logging loggingClient(@Qualifier(regionProviderQualifier) RegionProvider regionProvider,
51+
@Qualifier(credentialsProviderQualifier)
4752
BasicAuthenticationDetailsProvider adp) {
4853
com.oracle.bmc.loggingingestion.Logging logging = new LoggingClient(adp);
4954
if (regionProvider.getRegion() != null) logging.setRegion(regionProvider.getRegion());

spring-cloud-oci-autoconfigure/src/main/java/com/oracle/cloud/spring/notification/NotificationAutoConfiguration.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,16 @@
1111
import com.oracle.bmc.ons.NotificationControlPlaneClient;
1212
import com.oracle.bmc.ons.NotificationDataPlane;
1313
import com.oracle.bmc.ons.NotificationDataPlaneClient;
14+
import org.springframework.beans.factory.annotation.Qualifier;
1415
import org.springframework.boot.autoconfigure.AutoConfiguration;
1516
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
1617
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
1718
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
1819
import org.springframework.context.annotation.Bean;
1920

21+
import static com.oracle.cloud.spring.autoconfigure.core.CredentialsProviderAutoConfiguration.credentialsProviderQualifier;
22+
import static com.oracle.cloud.spring.autoconfigure.core.RegionProviderAutoConfiguration.regionProviderQualifier;
23+
2024
/**
2125
* Auto-configuration for initializing the OCI Notification component.
2226
* Depends on {@link com.oracle.cloud.spring.autoconfigure.core.CredentialsProviderAutoConfiguration} and
@@ -38,7 +42,8 @@ Notification getNotificationImpl(NotificationDataPlane notificationDataPlane, No
3842

3943
@Bean
4044
@ConditionalOnMissingBean
41-
NotificationDataPlane notificationDataPlaneClient(RegionProvider regionProvider,
45+
NotificationDataPlane notificationDataPlaneClient(@Qualifier(regionProviderQualifier) RegionProvider regionProvider,
46+
@Qualifier(credentialsProviderQualifier)
4247
BasicAuthenticationDetailsProvider adp) {
4348
NotificationDataPlane notificationDataPlaneClient = new NotificationDataPlaneClient(adp);
4449
if (regionProvider.getRegion() != null) notificationDataPlaneClient.setRegion(regionProvider.getRegion());
@@ -47,7 +52,8 @@ NotificationDataPlane notificationDataPlaneClient(RegionProvider regionProvider,
4752

4853
@Bean
4954
@ConditionalOnMissingBean
50-
NotificationControlPlane notificationControlPlaneClient(RegionProvider regionProvider,
55+
NotificationControlPlane notificationControlPlaneClient(@Qualifier(regionProviderQualifier) RegionProvider regionProvider,
56+
@Qualifier(credentialsProviderQualifier)
5157
BasicAuthenticationDetailsProvider adp) {
5258
NotificationControlPlane notificationControlPlaneClient = new NotificationControlPlaneClient(adp);
5359
if (regionProvider.getRegion() != null) notificationControlPlaneClient.setRegion(regionProvider.getRegion());

spring-cloud-oci-autoconfigure/src/main/java/com/oracle/cloud/spring/storage/StorageAutoConfiguration.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import com.oracle.bmc.auth.RegionProvider;
1111
import com.oracle.bmc.objectstorage.ObjectStorageClient;
1212
import com.oracle.cloud.spring.core.compartment.CompartmentProvider;
13+
import org.springframework.beans.factory.annotation.Qualifier;
1314
import org.springframework.boot.autoconfigure.AutoConfiguration;
1415
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
1516
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
@@ -20,6 +21,9 @@
2021

2122
import java.util.Optional;
2223

24+
import static com.oracle.cloud.spring.autoconfigure.core.CredentialsProviderAutoConfiguration.credentialsProviderQualifier;
25+
import static com.oracle.cloud.spring.autoconfigure.core.RegionProviderAutoConfiguration.regionProviderQualifier;
26+
2327
/**
2428
* Auto-configuration for initializing the OCI Storage component.
2529
* Depends on {@link com.oracle.cloud.spring.autoconfigure.core.CompartmentProviderAutoConfiguration},
@@ -48,7 +52,8 @@ Storage storageActions(ObjectStorageClient osClient, StorageOutputStreamProvider
4852

4953
@Bean
5054
@ConditionalOnMissingBean
51-
ObjectStorageClient objectStorageClient(RegionProvider regionProvider,
55+
ObjectStorageClient objectStorageClient(@Qualifier(regionProviderQualifier) RegionProvider regionProvider,
56+
@Qualifier(credentialsProviderQualifier)
5257
BasicAuthenticationDetailsProvider adp) {
5358
ObjectStorageClient osClient = new ObjectStorageClient(adp);
5459
if (regionProvider.getRegion() != null) osClient.setRegion(regionProvider.getRegion());

0 commit comments

Comments
 (0)