Skip to content

Commit 5c262fe

Browse files
Json collections cleanup (#144)
Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
1 parent 6f9ca58 commit 5c262fe

File tree

4 files changed

+0
-97
lines changed

4 files changed

+0
-97
lines changed

database/starters/oracle-spring-boot-starter-json-collections/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,6 @@
5959
<artifactId>spring-boot-starter-jdbc</artifactId>
6060
</dependency>
6161

62-
<dependency>
63-
<groupId>com.oracle.database.soda</groupId>
64-
<artifactId>orajsoda</artifactId>
65-
</dependency>
66-
6762
<dependency>
6863
<groupId>jakarta.json</groupId>
6964
<artifactId>jakarta.json-api</artifactId>

database/starters/oracle-spring-boot-starter-json-collections/src/main/java/com/oracle/spring/json/JsonCollectionsAutoConfiguration.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,7 @@
33
package com.oracle.spring.json;
44

55
import com.oracle.spring.json.jsonb.JSONB;
6-
import com.oracle.spring.json.jsonb.SODA;
76
import jakarta.json.bind.JsonbBuilder;
8-
import oracle.soda.OracleDocument;
9-
import oracle.soda.rdbms.OracleRDBMSClient;
107
import oracle.sql.json.OracleJsonFactory;
118
import org.eclipse.yasson.YassonJsonb;
129
import org.springframework.boot.autoconfigure.AutoConfiguration;
@@ -27,21 +24,9 @@ YassonJsonb yassonJsonb() {
2724
return (YassonJsonb) JsonbBuilder.create();
2825
}
2926

30-
@Bean
31-
@ConditionalOnClass(OracleRDBMSClient.class)
32-
OracleRDBMSClient oracleRDBMSClient() {
33-
return new OracleRDBMSClient();
34-
}
35-
3627
@Bean
3728
@ConditionalOnClass({OracleJsonFactory.class, YassonJsonb.class})
3829
public JSONB jsonb(OracleJsonFactory oracleJsonFactory, YassonJsonb yassonJsonb) {
3930
return new JSONB(oracleJsonFactory, yassonJsonb);
4031
}
41-
42-
@Bean
43-
@ConditionalOnClass({OracleJsonFactory.class, YassonJsonb.class, OracleDocument.class})
44-
public SODA soda(OracleJsonFactory oracleJsonFactory, YassonJsonb yassonJsonb) {
45-
return new SODA(oracleJsonFactory, yassonJsonb);
46-
}
4732
}

database/starters/oracle-spring-boot-starter-json-collections/src/main/java/com/oracle/spring/json/jsonb/SODA.java

Lines changed: 0 additions & 41 deletions
This file was deleted.

database/starters/oracle-spring-boot-starter-json-collections/src/test/java/com/oracle/spring/json/JsonCollectionsIT.java

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,16 @@
33
package com.oracle.spring.json;
44

55
import javax.sql.DataSource;
6-
import java.sql.Connection;
76
import java.sql.PreparedStatement;
87
import java.time.Duration;
98
import java.util.List;
109
import java.util.UUID;
1110

1211
import com.oracle.spring.json.jsonb.JSONB;
1312
import com.oracle.spring.json.jsonb.JSONBRowMapper;
14-
import com.oracle.spring.json.jsonb.SODA;
1513
import com.oracle.spring.json.test.Student;
1614
import com.oracle.spring.json.test.StudentDetails;
1715
import oracle.jdbc.OracleTypes;
18-
import oracle.soda.OracleCollection;
19-
import oracle.soda.OracleDatabase;
20-
import oracle.soda.OracleDocument;
21-
import oracle.soda.rdbms.OracleRDBMSClient;
2216
import oracle.ucp.jdbc.PoolDataSource;
2317
import oracle.ucp.jdbc.PoolDataSourceFactory;
2418
import org.junit.jupiter.api.BeforeAll;
@@ -45,21 +39,12 @@ public class JsonCollectionsIT {
4539

4640
@Autowired
4741
JSONB jsonb;
48-
@Autowired
49-
SODA soda;
50-
@Autowired
51-
OracleRDBMSClient client;
5242

5343
Student student1 = new Student(Student.newId(), "Bob", new StudentDetails(
5444
"Computer Science",
5545
3.33,
5646
64
5747
));
58-
Student student2 = new Student(Student.newId(), "Alice", new StudentDetails(
59-
"Mathematics",
60-
3.8,
61-
80
62-
));
6348

6449
@BeforeAll
6550
static void setUp() throws Exception {
@@ -95,25 +80,4 @@ create table student (
9580
assertThat(students).hasSize(1);
9681
assertThat(students.get(0)).isEqualTo(student1);
9782
}
98-
99-
@Test
100-
void sodaMapping() throws Exception {
101-
try (Connection conn = dataSource.getConnection()) {
102-
OracleDatabase db = client.getDatabase(conn);
103-
db.admin().createCollection("student_soda");
104-
OracleCollection col = db.openCollection("student_soda");
105-
106-
OracleDocument document1 = soda.toDocument(db, student1);
107-
OracleDocument document2 = soda.toDocument(db, student2);
108-
109-
col.insert(document1);
110-
col.insert(document2);
111-
112-
OracleDocument found = col.find().filter("{\"name\":\"Alice\"}")
113-
.getOne();
114-
115-
Student student = soda.fromDocument(found, Student.class);
116-
assertThat(student).isEqualTo(student2);
117-
}
118-
}
11983
}

0 commit comments

Comments
 (0)