Skip to content

Commit 1a7a444

Browse files
committed
eeeeep
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
1 parent 116e65d commit 1a7a444

File tree

6 files changed

+27
-24
lines changed

6 files changed

+27
-24
lines changed

spring-cloud-oci-adb/src/main/java/com/oracle/cloud/spring/adb/AutonomousDatabase.java renamed to spring-cloud-oci-adb/src/main/java/com/oracle/cloud/spring/adb/AutonomousDb.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44
package com.oracle.cloud.spring.adb;
55

66
import com.oracle.bmc.database.DatabaseClient;
7+
import com.oracle.bmc.database.model.AutonomousDatabase;
78
import com.oracle.bmc.database.responses.CreateAutonomousDatabaseResponse;
8-
import com.oracle.bmc.database.responses.GetAutonomousDatabaseResponse;
99
import com.oracle.bmc.database.responses.GenerateAutonomousDatabaseWalletResponse;
1010
import com.oracle.bmc.database.responses.DeleteAutonomousDatabaseResponse;
1111

1212
/**
1313
* Interface for OCI Autonomous Database module.
1414
*/
15-
public interface AutonomousDatabase {
15+
public interface AutonomousDb {
1616

1717
/**
1818
* Direct instance of OCI Java SDK DatabaseClient.
@@ -41,7 +41,7 @@ CreateAutonomousDatabaseResponse createAutonomousDatabase(
4141
* @param databaseId OCID of the Autonomous Database to get details of
4242
* @return GetAutonomousDatabaseResponse
4343
*/
44-
GetAutonomousDatabaseResponse getAutonomousDatabase(String databaseId);
44+
AutonomousDatabase getAutonomousDatabase(String databaseId);
4545

4646
/**
4747
* Generate a wallet for an Autonomous Database.

spring-cloud-oci-adb/src/main/java/com/oracle/cloud/spring/adb/AutonomousDatabaseImpl.java renamed to spring-cloud-oci-adb/src/main/java/com/oracle/cloud/spring/adb/AutonomousDbImpl.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
package com.oracle.cloud.spring.adb;
55

66
import com.oracle.bmc.database.DatabaseClient;
7+
import com.oracle.bmc.database.model.AutonomousDatabase;
78
import com.oracle.bmc.database.model.CreateAutonomousDatabaseBase;
89
import com.oracle.bmc.database.model.CreateAutonomousDatabaseDetails;
910
import com.oracle.bmc.database.model.GenerateAutonomousDatabaseWalletDetails;
@@ -19,11 +20,11 @@
1920
/**
2021
* Implementation for the OCI Autonomous Database module.
2122
*/
22-
public class AutonomousDatabaseImpl implements AutonomousDatabase {
23+
public class AutonomousDbImpl implements AutonomousDb {
2324

2425
final DatabaseClient client;
2526

26-
public AutonomousDatabaseImpl(DatabaseClient client) {
27+
public AutonomousDbImpl(DatabaseClient client) {
2728
this.client = client;
2829
}
2930

@@ -71,14 +72,17 @@ public CreateAutonomousDatabaseResponse createAutonomousDatabase(
7172
* @param databaseId OCID of the Autonomous Database to get details of
7273
* @return GetAutonomousDatabaseResponse
7374
*/
74-
public GetAutonomousDatabaseResponse getAutonomousDatabase(String databaseId) {
75+
public AutonomousDatabase getAutonomousDatabase(String databaseId) {
7576
GetAutonomousDatabaseRequest getAutonomousDatabaseRequest = GetAutonomousDatabaseRequest.builder()
7677
.autonomousDatabaseId(databaseId)
7778
.build();
7879

7980
GetAutonomousDatabaseResponse response = client.getAutonomousDatabase(getAutonomousDatabaseRequest);
81+
AutonomousDatabase adb = response.getAutonomousDatabase();
82+
83+
System.out.println("***\n" + adb);
8084

81-
return response;
85+
return adb;
8286
}
8387

8488
/**
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
package com.oracle.cloud.spring.adb;
55

66
import com.oracle.bmc.database.DatabaseClient;
7+
import com.oracle.bmc.database.model.AutonomousDatabase;
78
import com.oracle.bmc.database.responses.CreateAutonomousDatabaseResponse;
89
import com.oracle.bmc.database.responses.GetAutonomousDatabaseResponse;
910
import com.oracle.bmc.database.responses.GenerateAutonomousDatabaseWalletResponse;
@@ -15,11 +16,11 @@
1516
import static org.junit.jupiter.api.Assertions.assertNotNull;
1617
import static org.mockito.ArgumentMatchers.any;
1718

18-
public class AutonomousDatabaseImplTests {
19+
public class AutonomousDbImplTests {
1920

2021
final DatabaseClient client = mock(DatabaseClient.class);
2122

22-
final AutonomousDatabase autonomousDatabase = new AutonomousDatabaseImpl(client);
23+
final AutonomousDb autonomousDatabase = new AutonomousDbImpl(client);
2324

2425
@Test
2526
void testDatabaseClient() {
@@ -37,8 +38,8 @@ void testDatbaseImpl() {
3738
"name", "compartment", "password", 200, 2f);
3839
assertNotNull(cadr);
3940

40-
GetAutonomousDatabaseResponse gadr = autonomousDatabase.getAutonomousDatabase("ocid");
41-
assertNotNull(gadr);
41+
AutonomousDatabase gadr = autonomousDatabase.getAutonomousDatabase("ocid");
42+
//assertNotNull(gadr);
4243

4344
GenerateAutonomousDatabaseWalletResponse gadwr = autonomousDatabase.generateAutonomousDatabaseWallet("ocid", "password");
4445
assertNotNull(gadwr);
Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
package com.oracle.cloud.spring.adb;
55

6-
import com.oracle.bmc.Region;
76
import com.oracle.bmc.auth.RegionProvider;
87
import com.oracle.bmc.database.DatabaseClient;
98
import com.oracle.cloud.spring.autoconfigure.core.CredentialsProvider;
@@ -15,8 +14,6 @@
1514
import org.springframework.cloud.context.config.annotation.RefreshScope;
1615
import org.springframework.context.annotation.Bean;
1716

18-
import java.text.MessageFormat;
19-
2017
import static com.oracle.cloud.spring.autoconfigure.core.CredentialsProviderAutoConfiguration.credentialsProviderQualifier;
2118
import static com.oracle.cloud.spring.autoconfigure.core.RegionProviderAutoConfiguration.regionProviderQualifier;
2219

@@ -26,18 +23,18 @@
2623
* {@link com.oracle.cloud.spring.autoconfigure.core.RegionProviderAutoConfiguration}
2724
* for loading the Authentication configuration
2825
*
29-
* @see com.oracle.cloud.spring.adb.AutonomousDatabase
26+
* @see com.oracle.cloud.spring.adb.AutonomousDb
3027
*/
3128
@AutoConfiguration
32-
@ConditionalOnClass({AutonomousDatabase.class})
29+
@ConditionalOnClass({AutonomousDb.class})
3330
@ConditionalOnProperty(name = "spring.cloud.oci.adb.enabled", havingValue = "true", matchIfMissing = true)
34-
public class AutonomousDatabaseAutoConfiguration {
31+
public class AutonomousDbAutoConfiguration {
3532

3633
@Bean
3734
@RefreshScope
38-
@ConditionalOnMissingBean(AutonomousDatabase.class)
39-
AutonomousDatabase getQueueImpl(DatabaseClient databaseClient) {
40-
return new AutonomousDatabaseImpl(databaseClient);
35+
@ConditionalOnMissingBean(AutonomousDb.class)
36+
AutonomousDb getQueueImpl(DatabaseClient databaseClient) {
37+
return new AutonomousDbImpl(databaseClient);
4138
}
4239

4340
@Bean

spring-cloud-oci-autoconfigure/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ com.oracle.cloud.spring.streaming.StreamingAutoConfiguration
99
com.oracle.cloud.spring.queue.QueueAutoConfiguration
1010
com.oracle.cloud.spring.genai.GenAIAutoConfiguration
1111
com.oracle.cloud.spring.vault.VaultAutoConfiguration
12-
com.oracle.cloud.spring.adb.AutonomousDatabaseAutoConfiguration
12+
com.oracle.cloud.spring.adb.AutonomousDbAutoConfiguration

spring-cloud-oci-samples/spring-cloud-oci-adb-samples/src/main/java/com/oracle/cloud/spring/sample/adb/springcloudociadbsample/AdbController.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@
33

44
package com.oracle.cloud.spring.sample.adb.springcloudociadbsample;
55

6+
import com.oracle.bmc.database.model.AutonomousDatabase;
67
import com.oracle.bmc.database.responses.CreateAutonomousDatabaseResponse;
78
import com.oracle.bmc.database.responses.DeleteAutonomousDatabaseResponse;
89
import com.oracle.bmc.database.responses.GenerateAutonomousDatabaseWalletResponse;
910
import com.oracle.bmc.database.responses.GetAutonomousDatabaseResponse;
10-
import com.oracle.cloud.spring.adb.AutonomousDatabase;
11+
import com.oracle.cloud.spring.adb.AutonomousDb;
1112
import io.swagger.v3.oas.annotations.Parameter;
1213
import io.swagger.v3.oas.annotations.tags.Tag;
1314
import org.springframework.beans.factory.annotation.Autowired;
@@ -25,7 +26,7 @@
2526
public class AdbController {
2627

2728
@Autowired
28-
AutonomousDatabase autonomousDatabase;
29+
AutonomousDb autonomousDatabase;
2930

3031
@PostMapping
3132
ResponseEntity<?> createAutonomousDatabase(
@@ -42,7 +43,7 @@ ResponseEntity<?> createAutonomousDatabase(
4243

4344
@GetMapping
4445
ResponseEntity<?> getAutonomousDatabase(@Parameter(required = true, example = "databaseId") @RequestParam String databaseId) {
45-
GetAutonomousDatabaseResponse response = autonomousDatabase.getAutonomousDatabase(databaseId);
46+
AutonomousDatabase response = autonomousDatabase.getAutonomousDatabase(databaseId);
4647
return ResponseEntity.ok().body(response);
4748
}
4849

0 commit comments

Comments
 (0)