Skip to content

Commit fe8522d

Browse files
l-technicoreYashwantGohokar
authored andcommitted
Bugfix: Ensure backend ssl certificates during Update LoadBalancer Backendsets flow
1 parent 346136f commit fe8522d

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

pkg/cloudprovider/providers/oci/load_balancer.go

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1229,6 +1229,22 @@ func (cp *CloudProvider) UpdateLoadBalancer(ctx context.Context, clusterName str
12291229
return err
12301230
}
12311231

1232+
var sslConfig *SSLConfig
1233+
if requiresCertificate(service) {
1234+
ports, err := getSSLEnabledPorts(service)
1235+
if err != nil {
1236+
logger.With(zap.Error(err)).Error("Failed to parse SSL port.")
1237+
errorType = util.GetError(err)
1238+
lbMetricDimension = util.GetMetricDimensionForComponent(errorType, util.LoadBalancerType)
1239+
dimensionsMap[metrics.ComponentDimension] = lbMetricDimension
1240+
metrics.SendMetricData(cp.metricPusher, getMetric(loadBalancerType, Update), time.Since(startTime).Seconds(), dimensionsMap)
1241+
return err
1242+
}
1243+
secretListenerString := service.Annotations[ServiceAnnotationLoadBalancerTLSSecret]
1244+
secretBackendSetString := service.Annotations[ServiceAnnotationLoadBalancerTLSBackendSetSecret]
1245+
sslConfig = NewSSLConfig(secretListenerString, secretBackendSetString, service, ports, cp)
1246+
}
1247+
12321248
subnets, err := cp.getLoadBalancerSubnets(ctx, logger, service)
12331249
if err != nil {
12341250
logger.With(zap.Error(err)).Error("Failed to get Load balancer Subnets.")
@@ -1239,7 +1255,7 @@ func (cp *CloudProvider) UpdateLoadBalancer(ctx context.Context, clusterName str
12391255
return err
12401256
}
12411257

1242-
spec, err := NewLBSpec(logger, service, nodes, subnets, nil, cp.securityListManagerFactory, cp.config.Tags, lb)
1258+
spec, err := NewLBSpec(logger, service, nodes, subnets, sslConfig, cp.securityListManagerFactory, cp.config.Tags, lb)
12431259
if err != nil {
12441260
logger.With(zap.Error(err)).Error("Failed to derive LBSpec")
12451261
errorType = util.GetError(err)

0 commit comments

Comments
 (0)