Extract check for empty config files

Author: dnestoro

tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/ContributionTask.java

@@ -464,13 +464,13 @@ private void removeEmptyConfigFiles() throws IOException {
 
         Path resourceConfigPath = metadataDirectory.resolve(CONFIG_FILES.RESOURCE.get());
         ResourceConfigModel resourceConfig = objectMapper.readValue(new File(resourceConfigPath.toUri()), new TypeReference<>() {});
-        if (resourceConfig.bundles().isEmpty() && resourceConfig.resources().toString().equalsIgnoreCase("{}")) {
+        if (resourceConfig.isEmpty()) {
             removeConfigFile(resourceConfigPath, CONFIG_FILES.RESOURCE, remainingFiles);
         }
 
         Path serializationConfigPath = metadataDirectory.resolve(CONFIG_FILES.SERIALIZATION.get());
         SerializationConfigModel serializationConfig = objectMapper.readValue(new File(serializationConfigPath.toUri()), new TypeReference<>() {});
-        if (serializationConfig.lambdaCapturingTypes().isEmpty() && serializationConfig.types().isEmpty() && serializationConfig.proxies().isEmpty()) {
+        if (serializationConfig.isEmpty()) {
             removeConfigFile(serializationConfigPath, CONFIG_FILES.SERIALIZATION, remainingFiles);
         }
 
@@ -495,7 +495,7 @@ private void removeEmptyConfigFiles() throws IOException {
         Path predefinedClassesConfigPath = metadataDirectory.resolve(CONFIG_FILES.PREDEFINED_CLASSES.get());
         List<PredefinedClassesConfigModel> predefinedClassesConfig = objectMapper.readValue(new File(predefinedClassesConfigPath.toUri()), new TypeReference<>() {});
         if (predefinedClassesConfig.size() == 1) {
-            if (predefinedClassesConfig.get(0).type().equalsIgnoreCase("agent-extracted") && predefinedClassesConfig.get(0).classes().isEmpty()) {
+            if (predefinedClassesConfig.get(0).isEmpty()) {
                 removeConfigFile(predefinedClassesConfigPath, CONFIG_FILES.PREDEFINED_CLASSES, remainingFiles);
             }
         }

tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/model/contributing/PredefinedClassesConfigModel.java

@@ -6,4 +6,7 @@ public record PredefinedClassesConfigModel(
         String type,
         List<Object> classes
 ) {
+    public boolean isEmpty() {
+        return this.type().equalsIgnoreCase("agent-extracted") && this.classes().isEmpty();
+    }
 }

tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/model/contributing/ResourceConfigModel.java

@@ -5,4 +5,7 @@ public record ResourceConfigModel(
         Object resources,
         List<Object> bundles
 ) {
+    public boolean isEmpty() {
+        return this.bundles().isEmpty() && this.resources().toString().equalsIgnoreCase("{}");
+    }
 }

tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/model/contributing/SerializationConfigModel.java

@@ -8,4 +8,7 @@ public record SerializationConfigModel(
         List<Object> proxies,
         List<Object> lambdaCapturingTypes
 ) {
+    public boolean isEmpty() {
+        return this.lambdaCapturingTypes().isEmpty() && this.types().isEmpty() && this.proxies().isEmpty();
+    }
 }

tests/tck-build-logic/src/main/resources/contributing/questions.json

@@ -6,7 +6,7 @@
   },
   {
     "question-key": "testsLocation",
-    "question": "Where are your tests implemented? Absolute path to the directory containing java packages where you implemented tests: ",
+    "question": "Where did you implemented tests for this library? Absolute path to the directory containing java packages where you implemented tests: ",
     "help": "An absolute path to the directory that contains your tests. This path must be on your system and not some online location. Be aware that for all tests where you are not the sole author, you have to add a comment that proves that you may publish them under the specified license manually"
   },
   {
@@ -27,11 +27,11 @@
   {
     "question-key": "additionalDependencies",
     "question": "What additional testImplementation dependencies you want to include? Enter the next dependency (to stop type \"-\")",
-    "help": "Enter the testImplementation dependencies (pres enter after each dependency) you want to include use in tests. Provide dependencies in form of Maven coordinates. Maven coordinates consist of three parts in the following format \"groupId:artifactId:version\". For more information visit: https://maven.apache.org/repositories/artifacts.html When you finish adding dependencies, type \"-\" to terminate the inclusion process"
+    "help": "Enter the testImplementation dependencies (press enter after each dependency) you want to include use in tests. Provide dependencies in form of Maven coordinates. Maven coordinates consist of three parts in the following format \"groupId:artifactId:version\". For more information visit: https://maven.apache.org/repositories/artifacts.html When you finish adding dependencies, type \"-\" to terminate the inclusion process"
   },
   {
     "question-key": "shouldCreatePullRequest",
     "question": "Do you want to create a pull request to the reachability metadata repository [Y/n]:",
-    "help": "In case you want to open a pull request to Reachability metadata repository automatically, type \"y\". This way the task will create a new branch for you, commit changes with a proper message, and push the branch remotly. At the end, the task will give you a link to the Github repository where you should fill in a pull request checkslist and complete the process."
+    "help": "In case you want to open a pull request to Reachability metadata repository automatically, type \"y\". This way the task will create a new branch for you, commit changes with a proper message, and push the branch remotely. At the end, the task will give you a link to the Github repository where you should fill in a pull request checklist and complete the process."
   }
 ]