Skip to content

Commit 9ca25a4

Browse files
authored
Merge pull request #147 from oracle/fix/materialized_view
Fix ORA-12098: cannot comment on the materialized view
2 parents 2c107d4 + 4268795 commit 9ca25a4

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

dbt/include/oracle/macros/adapters.sql

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,8 +260,12 @@
260260

261261
{% macro oracle__alter_relation_comment(relation, comment) %}
262262
{% set escaped_comment = oracle_escape_comment(comment) %}
263+
{% if relation.type == 'materialized_view' %}
264+
comment on materialized view {{ relation }} is {{ escaped_comment }}
265+
{% else %}
263266
{# "comment on table" even for views #}
264267
comment on table {{ relation }} is {{ escaped_comment }}
268+
{% endif %}
265269
{% endmacro %}
266270

267271
{% macro oracle__persist_docs(relation, model, for_relation, for_columns) -%}

dbt_adbs_test_project/models/sales_internet_mv.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@
1313
See the License for the specific language governing permissions and
1414
limitations under the License.
1515
#}
16-
{{ config(materialized='materialized_view')}}
16+
{{ config(materialized='materialized_view', persist_docs={"relation": true, "columns": true}) }}
1717
select * from {{ source('sh_database', 'sales') }}
1818
where channel_id = 5

dbt_adbs_test_project/models/schema.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ sources:
2222
- name: costs
2323

2424
models:
25+
- name: sales_internet_mv
26+
description: Test comment for Materialized View
27+
2528
- name: kafka
2629
description: kafka_description
2730
config:

0 commit comments

Comments
 (0)